Skip to content

typed-protocol's annotated driver: bugfix #5207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
+17 −2
Merged

typed-protocol's annotated driver: bugfix #5207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ...ork/changelog.d/20251020_193107_crocodile-dentist_bugfix_runannotateddecoder.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
<!--
A new scriv changelog fragment.

Uncomment the section that is right (remove the HTML comment wrapper).
For top level release notes, leave all the headers commented out.
-->

<!--
### Breaking

- A bullet item for the Breaking category.


### Non-Breaking

- bugfix `runAnnotatedDecoderWithChannel`
3 changes: 1 addition & 2 deletions ouroboros-network/framework/lib/Ouroboros/Network/Driver/Simple.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ import Control.Monad.Class.MonadFork
import Control.Monad.Class.MonadThrow
import Control.Tracer (Tracer (..), contramap, traceWith)
import Data.Functor.Identity (Identity (..))
import Data.Maybe (maybeToList)


-- $intro
Expand Down Expand Up @@ -327,7 +326,7 @@ runAnnotatedDecoderWithChannel
-> DecodeStep bytes failure m (bytes -> a)
-> m (Either failure (a, Maybe bytes))

runAnnotatedDecoderWithChannel Channel{recv} bs0 = go (maybeToList bs0) bs0
runAnnotatedDecoderWithChannel Channel{recv} = go []
where
go :: [bytes]
-> Maybe bytes
Expand Down