Skip to content
This repository was archived by the owner on Feb 3, 2022. It is now read-only.

Update startercode branch to v2.0.0 - #80

Merged
jimmychu0807 merged 1 commit into
apopiak-new-startercodefrom
df/update/startercode
Mar 17, 2021
Merged

Update startercode branch to v2.0.0#80
jimmychu0807 merged 1 commit into
apopiak-new-startercodefrom
df/update/startercode

Conversation

@danforbes

Copy link
Copy Markdown

Bump #79 to v2.0.0

@danforbes
danforbes marked this pull request as draft January 2, 2021 18:01
@zbraniecki

Copy link
Copy Markdown

I'm seeing the following error on the current nightly:

error[E0282]: type annotations needed
    --> /home/zbraniecki/.cargo/registry/src/github.com-1ecc6299db9ec823/sp-arithmetic-2.0.0/src/fixed_point.rs:541:9
     |
541  |                   let accuracy = P::ACCURACY.saturated_into();
     |                       ^^^^^^^^ consider giving `accuracy` a type
...
1595 | / implement_fixed!(
1596 | |     FixedI64,
1597 | |     test_fixed_i64,
1598 | |     i64,
...    |
1601 | |     "_Fixed Point 64 bits signed, range = [-9223372036.854775808, 9223372036.854775807]_",
1602 | | );
     | |__- in this macro invocation
     |
     = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

@jimmychu0807

Copy link
Copy Markdown

I am merging this for now, because it is better than the previous version.

But @zbraniecki, I think another upgrade to v2.0.1 will fix the issue you have.

@jimmychu0807
jimmychu0807 marked this pull request as ready for review March 17, 2021 09:26
@jimmychu0807
jimmychu0807 merged commit c59afd8 into apopiak-new-startercode Mar 17, 2021
@jimmychu0807
jimmychu0807 deleted the df/update/startercode branch March 17, 2021 09:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants