Fix free_function_commands test #1150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrong order of arguments
keryell
approved these changes
Nov 7, 2025
Member
keryell
left a comment
keryell
left a comment
There was a problem hiding this comment.
Good catch! Thanks.
Probably we should have a mode where we would run with a sanitizer or write the test differently to catch issues like these.
tomdeakin
approved these changes
Nov 11, 2025
Contributor
|
WG discussed this, and we should check |
Contributor
Author
|
@tomdeakin should I update the patch? |
Contributor
|
Yes please @KornevNikita ! |
Contributor
Author
|
@tomdeakin updated. |
tomdeakin
approved these changes
Dec 3, 2025
Contributor
|
WG approved to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong order of arguments. Also updating CHECKs to properly verify results.
spec: KhronosGroup/SYCL-Docs#922