Skip to content

Fix free_function_commands test #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomdeakin merged 2 commits into from
Dec 4, 2025
Merged

Fix free_function_commands test #1150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58c99db
Fix free_function_commands test
KornevNikita Oct 23, 2025
2a1ce82
apply review suggestions
KornevNikita Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions tests/extension/khr_free_function_commands/free_function_commands.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ static void test_memcpy() {
q.wait();

for (int i = 0; i < N; ++i) {
CHECK(src[i] == dst[i]);
CHECK(dst[i] == i);
dst[i] = 0;
}
}
Expand All @@ -266,7 +266,7 @@ static void test_memcpy() {
q.wait();

for (int i = 0; i < N; ++i) {
CHECK(src[i] == dst[i]);
CHECK(dst[i] == i);
dst[i] = 0;
}
}
Expand All @@ -286,17 +286,17 @@ static void test_copy_usm_pointers_impl() {
std::iota(src, src + N, 0);

{
q.submit([&](sycl::handler& h) { sycl::khr::copy(h, dst, src, N); });
q.submit([&](sycl::handler& h) { sycl::khr::copy(h, src, dst, N); });
q.wait();
for (int i = 0; i < N; ++i) {
CHECK(src[i] == dst[i]);
CHECK(dst[i] == i);
dst[i] = 0;
}
}
{
sycl::khr::copy(q, dst, src, N);
sycl::khr::copy(q, src, dst, N);
q.wait();
for (int i = 0; i < N; ++i) CHECK(src[i] == dst[i]);
for (int i = 0; i < N; ++i) CHECK(dst[i] == i);
}

sycl::free(src, q);
Expand Down Expand Up @@ -333,7 +333,7 @@ static void test_copy_accessors_host_to_device_impl() {
}
}

for (size_t i = 0; i < N; ++i) CHECK(src[i] == dst[i]);
for (size_t i = 0; i < N; ++i) CHECK(dst[i] == i);
};

T src[N] = {0};
Expand Down Expand Up @@ -378,7 +378,7 @@ static void test_copy_accessors_device_to_host_impl() {
}
}

for (size_t i = 0; i < N; ++i) CHECK(src[i] == dst[i]);
for (size_t i = 0; i < N; ++i) CHECK(dst[i] == i);
};

T dst[N] = {0};
Expand Down Expand Up @@ -427,7 +427,7 @@ static void test_copy_accessors_device_to_device_impl() {
}

for (size_t i = 0; i < N; ++i) {
CHECK(src[i] == dst[i]);
CHECK(dst[i] == i);
}
};

Expand Down