-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare parts of std in KCL rather than Rust #5147
base: main
Are you sure you want to change the base?
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3e7c648
to
f8a47c6
Compare
381f6ce
to
18fdd1c
Compare
280861b
to
87f6cef
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5147 +/- ##
==========================================
+ Coverage 85.85% 86.10% +0.24%
==========================================
Files 94 95 +1
Lines 34639 35293 +654
==========================================
+ Hits 29741 30390 +649
- Misses 4898 4903 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR lets us declare consts and functions (which can be written in either KCL (no example in this PR) or Rust) in std using KCL (which lets us have consts in std and thus in code-completions and docs), it moves the in-memory constants to std and introduces constants to replace the (now-deprecated) functions for maths constants (the latter are breaking changes, but I've left the old functions for now). I've moved
cos
to KCL as a test case (not a breaking change). This PR shouldn't break any code.Outstanding work: