Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: E2E playwright test is permantely broken on localhost runtime on ubuntu. #5391

Merged
merged 4 commits into from
Feb 14, 2025

Conversation

nadr0
Copy link
Collaborator

@nadr0 nadr0 commented Feb 14, 2025

Issue

2 failed
[chromium] › zoo-test.ts:86:10 › Point-and-click tests › Shell point-and-click sketch on face (extrudes in pipes: true) @skipWin
[chromium] › zoo-test.ts:86:10 › Point-and-click tests › Shell point-and-click sketch on face (extrudes in pipes: false) @skipWin

These two tests fail 100% of the time on localhost

Implementation

  • If the screen size is too small (1000px) this forces us to close the code pane.
  • If the code pane is closed the activeLine logic within code mirror does not work properly
  • If the code pane is opened and the screen size is small you lose even more screen space because of the on hover resize widget from code mirror (picture below)
  • Opening and closing the code pane within the test leads to wrong application logic. We do not select the "correct" activeLines when the code pane is closed and the test says we are supposed to. This is wrong based on current application logic.

How I fixed this

  • Increase screen size to 1200 to have more space to click the surface to shell
  • clicked a new x,y point
  • updated the color we expect since I am clicking a new x,y point

image

@nadr0 nadr0 requested a review from pierremtb February 14, 2025 19:42
Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 14, 2025 8:38pm

Copy link

qa-wolf bot commented Feb 14, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link
Collaborator

@pierremtb pierremtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pierremtb pierremtb enabled auto-merge (squash) February 14, 2025 20:40
@pierremtb pierremtb disabled auto-merge February 14, 2025 20:49
@pierremtb pierremtb merged commit 8dd2571 into main Feb 14, 2025
32 of 33 checks passed
@pierremtb pierremtb deleted the nadro/adhoc/bricked-e2e-tests-locally branch February 14, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants