Skip to content

feat(node)!: require Node.js 22 or newer - #305

Merged
swkeever merged 1 commit into
mainfrom
vol-1094-node-22
Oct 7, 2026
Merged

feat(node)!: require Node.js 22 or newer#305
swkeever merged 1 commit into
mainfrom
vol-1094-node-22

Conversation

@swkeever

@swkeever swkeever commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

Tracking

Tracks: https://konghq.atlassian.net/browse/VOL-1094 (epic VOL-1077)

Summary

Sean decided to drop Node.js 20, which reached end-of-life on 2026-04-30. Current dev tooling has moved past it: orval 8.38+ calls Map.groupBy (#297), and Stryker 10 declares node >=22 (#301).

  • engines.node: >=20 → >=22.
  • CI: removes the SDK Node 20 lint, tests, and build job. Every SDK Node 22 mutation shard job already runs pnpm quality (policy, all nonmutation checks and tests, then its mutation shard), so nothing that ran on Node 20 goes unchecked on Node 22. The SDK Lint, Tests, and Build and Quality Gate aggregators now expect 1 and 5 results. Their names, and the repo's required checks, don't change. scripts/mutation-scope.test.mts now asserts that no job pins a separate node-version.
  • @types/node: 20.19.43 → 22.20.5, the latest 22.x, so the types match the oldest supported runtime. The Dependabot comment that ties it to engines now says >=22.
  • Docs: CONTRIBUTING, docs/getting-started.md, docs/versions.md, the README's durable-runtime note, the Next.js example README, and maintainers/mutation-testing.md / quality-policy.md no longer mention Node 20. Comments in pnpm-workspace.yaml and the durable packaging test drop the Node 20 reasons and keep the ones that still apply.
  • Unchanged: tsconfig targets (ES2021/ES2022) also cover browser consumers, so they stay as they are. Babel targets node: 'current'. Release jobs stay on Node 24.

Release impact

The title and the commit use feat(node)!:, and the commit carries a BREAKING CHANGE: footer. The repo is at 1.15.1, and bump-minor-pre-major applies only below 1.0, so Release Please will make the next release 2.0.0. Its changelog will include the breaking-change note. The open release PR (#287, 1.16.0) will become 2.0.0 too.

Lockfile

pnpm install rewrote pnpm-lock.yaml in pnpm's own layout, as #303 expected for the first lockfile change after it. Apart from @types/node 22.20.5 (and the peer suffixes that name it), the parsed lockfile is unchanged.

Verification

Following the standing rule, I ran only the checks that cover this change. CI runs lint, the full suite and mutation.

  • node --test .quality-tools/mutation-scope.test.mjs: 7/7 pass.
  • pnpm test:types (build and both tsc projects with @types/node 22): pass. tsc -p tsconfig.tooling.json: pass.
  • jest __tests__/durable-runtime-packaging.test.ts: 6/6 pass.
  • bash .github/scripts/actionlint.sh: clean.
  • prettier --check on every changed file except the lockfile, which Prettier now ignores: clean.

🤖 Generated with Claude Code

@swkeever
feat(node)!: require Node.js 22 or newer
b92c554 
Node.js 20 reached end-of-life on 2026-04-30. Raise engines.node to >=22,
drop the Node 20 CI lane (every Node 22 mutation shard already runs the full
nonmutation checks), move @types/node to 22.x, and update the docs that
named Node 20.

BREAKING CHANGE: @volcano.dev/sdk now requires Node.js 22 or newer. Upgrade
server-side and build environments from Node.js 20 before updating. Browser
support is unchanged.
@swkeever
swkeever requested a review from a team as a code owner October 7, 2026 18:49
Copilot AI balanced review requested due to automatic review settings October 7, 2026 18:49
@swkeever

swkeever commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T18:51:36.797121Z b92c554 Manual request
🔒 Security Review ✅ Completed 2026-10-07T18:52:04.880293Z b92c554 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI reviewed Oct 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

swkeever added a commit that referenced this pull request Oct 7, 2026
@swkeever
ci(actions): label the v7 action pins with their versions
cf55606 
Dependabot moved actions/checkout, actions/setup-node and actions/setup-go
to v7 SHAs but left their '# v6' comments. Name the exact release each SHA
resolves to. The Node 20 job keeps its comments; #305 removes that job.
@swkeever swkeever mentioned this pull request Oct 7, 2026
Merged
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: b92c554ea1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: b92c554ea1

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@swkeever swkeever mentioned this pull request Oct 7, 2026
Merged
@swkeever
swkeever merged commit 3537b03 into main Oct 7, 2026
@swkeever
swkeever deleted the vol-1094-node-22 branch October 7, 2026 19:52
swkeever added a commit that referenced this pull request Oct 7, 2026
@swkeever
ci(actions): label the v7 action pins with their versions (#306)
96510b9 
Dependabot moved actions/checkout, actions/setup-node and actions/setup-go
to v7 SHAs but left their '# v6' comments. Name the exact release each SHA
resolves to. The Node 20 job keeps its comments; #305 removes that job.
@kong-volcano-app kong-volcano-app Bot mentioned this pull request Oct 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@swkeever