Skip to content

Replace console usage with centralized logger across all packages excluding extension base 4930#4931

Open
ruhil6789 wants to merge 3 commits into
Koniverse:subwallet-devfrom
ruhil6789:Replace-console-usage-with-centralized-logger-across-all-packages-excluding-extension-base-4930
Open

Replace console usage with centralized logger across all packages excluding extension base 4930#4931
ruhil6789 wants to merge 3 commits into
Koniverse:subwallet-devfrom
ruhil6789:Replace-console-usage-with-centralized-logger-across-all-packages-excluding-extension-base-4930

Conversation

@ruhil6789

Copy link
Copy Markdown

Description

This PR resolves critical TypeScript compilation errors caused by circular dependencies between extension-base and extension-dapp packages, and fixes missing logger imports across the codebase.

Problem

  • TypeScript circular dependency error: extension-baseextension-dapp
  • Missing logger imports causing compilation failures
  • Type errors in DebuggerAPI component

Fixes: [4930]

Solution

1. Break Circular Dependency

  • Created local logger implementation in extension-dapp to eliminate circular dependency with extension-base
  • Added packages/extension-dapp/src/logger.ts with SimpleLogger class
  • Updated extension-dapp/src/bundle.ts to use local logger instead of importing from extension-base

2. Fix TypeScript Configuration

  • Updated tsconfig.build.json and tsconfig.json for extension-base and extension-dapp
  • Removed circular project references while maintaining rootDir constraints
  • Ensured proper one-way dependency: extension-baseextension-dapp

3. Fix Missing Logger Imports

  • Added defaultLogger import in Notification.tsx
  • Added createLogger import and logger instance in TransactionSubmission.tsx
  • Removed unused logger declaration in Settings/index.tsx
  • Fixed type error in DebuggerAPI.tsx (undefined check for formValues?.api)

Changes

  • 216 files changed: 859 insertions(+), 452 deletions(-)
  • New file: packages/extension-dapp/src/logger.ts
  • Modified: TypeScript configs, logger imports across multiple components

Impact

Resolves TypeScript build errors (TS6059, TS6307, TS6202)
Maintains all rootDir configurations as required
No breaking changes to functionality
All logger functionality preserved

Testing

  • TypeScript compilation successful
  • No linter errors
  • All logger calls working correctly

Related Issues

Fixes TypeScript circular dependency and compilation errors

ruhil6789 and others added 3 commits December 30, 2025 18:11
- Replaced all console.* statements with logger calls across extension-base
- Added logger instances to all service files, API files, and utilities
- Fixed TypeScript errors related to missing logger declarations
- Test files (.spec.ts) intentionally left unchanged
- Break circular dependency between extension-base and extension-dapp by creating local logger in extension-dapp
- Add missing logger imports in extension-koni-ui components
- Fix TypeScript project references to resolve build errors
- Update tsconfig files to maintain rootDir while breaking circular dependencies
- Fix type errors in DebuggerAPI component
…ger-across-all-packages-excluding-extension-base-4930
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant