Replace console usage with centralized logger across all packages excluding extension base 4930

packages/extension-base/package.json

@@ -90,6 +90,7 @@
     "is-buffer": "^2.0.5",
     "joi": "^17.13.3",
     "json-rpc-engine": "^6.1.0",
+    "loglevel": "^1.8.1",
     "manta-extension-sdk": "^1.1.0",
     "moment": "^2.29.4",
     "protobufjs": "^7.5.4",

packages/extension-base/src/background/handlers/helpers.ts

@@ -1,14 +1,18 @@
 // Copyright 2019-2022 @polkadot/extension authors & contributors
 // SPDX-License-Identifier: Apache-2.0
 
+import { createLogger } from '@subwallet/extension-base/utils/logger';
+
+const backgroundHelpersLogger = createLogger('BackgroundHelpers');
+
 export function withErrorLog (fn: () => unknown): void {
   try {
     const p = fn();
 
     if (p && typeof p === 'object' && typeof (p as Promise<unknown>).catch === 'function') {
-      (p as Promise<unknown>).catch(console.error);
+      (p as Promise<unknown>).catch((e) => backgroundHelpersLogger.error('Error in withErrorLog promise', e));
     }
   } catch (e) {
-    console.error(e);
+    backgroundHelpersLogger.error('Error in withErrorLog', e);
   }
 }

packages/extension-base/src/background/handlers/subscriptions.ts

@@ -3,9 +3,12 @@
 
 import type { MessageTypesWithSubscriptions, SubscriptionMessageTypes } from '../types';
 
+import { createLogger } from '@subwallet/extension-base/utils/logger';
+
 type Subscriptions = Record<string, chrome.runtime.Port>;
 
 const subscriptions: Subscriptions = {};
+const subscriptionsLogger = createLogger('Subscriptions');
 
 // return a subscription callback, that will send the data to the caller via the port
 export function createSubscription<TMessageType extends MessageTypesWithSubscriptions> (id: string, port: chrome.runtime.Port): (data: SubscriptionMessageTypes[TMessageType]) => void {
@@ -27,6 +30,6 @@ export function unsubscribe (id: string): void {
   if (subscriptions[id]) {
     delete subscriptions[id];
   } else {
-    console.error(`Unable to unsubscribe from ${id}`);
+    subscriptionsLogger.error(`Unable to unsubscribe from ${id}`);
   }
 }

packages/extension-base/src/constants/index.ts

@@ -58,9 +58,13 @@ export const getSupportTokenPayFeeChain = () => {
   return Object.values(_SUPPORT_TOKEN_PAY_FEE_GROUP).flat();
 };
 
+import { createLogger } from '@subwallet/extension-base/utils/logger';
+
+const constantsLogger = createLogger('Constants');
+
 export const isChainSupportTokenPayFee = (chainSlug: string): boolean => {
   if (!chainSlug) {
-    console.error('You must provide chain slug!');
+    constantsLogger.error('You must provide chain slug!');
 
     return false;
   }

packages/extension-base/src/core/logic-validation/request.ts

@@ -16,8 +16,11 @@ import { BN_ZERO, combineEthFee, createPromiseHandler, isSameAddress, reformatAd
 import { validateAddressNetwork } from '@subwallet/extension-base/utils/cardano';
 import { isContractAddress, parseContractInput } from '@subwallet/extension-base/utils/eth/parseTransaction';
 import { getId } from '@subwallet/extension-base/utils/getId';
+import { createLogger } from '@subwallet/extension-base/utils/logger';
 import { isCardanoAddress, isCardanoBaseAddress, isCardanoRewardAddress, isSubstrateAddress } from '@subwallet/keyring';
 import { KeyringPair } from '@subwallet/keyring/types';
+
+const logicValidationLogger = createLogger('LogicValidation');
 import { getBitcoinAddressInfo } from '@subwallet/keyring/utils';
 import { isBitcoinAddress } from '@subwallet/keyring/utils/address/validate';
 import { keyring } from '@subwallet/ui-keyring';
@@ -262,7 +265,7 @@ export async function validationConnectMiddleware (koni: KoniState, url: string,
     const [message, name] = convertErrorMessage(message_);
     const error = new EvmProviderError(EvmProviderErrorType.CHAIN_DISCONNECTED, message, undefined, name);
 
-    console.error(error);
+    logicValidationLogger.error('Validation error: chain disconnected', error);
     errors.push(error);
   };
 
@@ -356,7 +359,7 @@ export async function validationEvmDataTransactionMiddleware (koni: KoniState, u
     const [message, name] = convertErrorMessage(message_);
     const error = new TransactionError(BasicTxErrorType.INVALID_PARAMS, message, undefined, name);
 
-    console.error(error);
+    logicValidationLogger.error('Validation error: invalid params', error);
     errors.push(error);
   };
 
@@ -555,7 +558,7 @@ export async function validationEvmSignMessageMiddleware (koni: KoniState, url:
     const [message, name] = convertErrorMessage(message_);
     const error = new EvmProviderError(EvmProviderErrorType.INVALID_PARAMS, message, undefined, name);
 
-    console.error(error);
+    logicValidationLogger.error('Validation error: invalid params in evm signature', error);
     errors.push(error);
   };
 
@@ -614,7 +617,7 @@ export async function validationEvmSignMessageMiddleware (koni: KoniState, url:
           throw new Error('Unsupported action');
       }
     } catch (e) {
-      console.error(e);
+      logicValidationLogger.error('Error in validationEvmSignMessageMiddleware', e);
       handleError((e as Error).message);
     }
   } else {
@@ -760,7 +763,7 @@ export async function validationCardanoSignDataMiddleware (koni: KoniState, url:
     const [message, name] = convertErrorMessage(message_);
     const error = new CardanoProviderError(CardanoProviderErrorType.INVALID_REQUEST, message, undefined, name);
 
-    console.error(error);
+    logicValidationLogger.error('Validation error: invalid request in cardano signature', error);
     errors.push(error);
   };
 
@@ -823,7 +826,7 @@ export async function validationBitcoinConnectMiddleware (koni: KoniState, url:
     const [message, name] = convertErrorMessage(message_);
     const error = new TransactionError(BasicTxErrorType.INVALID_PARAMS, message, undefined, name);
 
-    console.error(error);
+    logicValidationLogger.error('Validation error: invalid params', error);
     errors.push(error);
   };
 
@@ -1074,7 +1077,7 @@ export async function validationBitcoinSendTransactionMiddleware (koni: KoniStat
       const [message, name] = [t('bg.TRANSACTION.core.validation.request.enableChainOnExtension', { replace: { chain: chainInfo.name } }), t('bg.TRANSACTION.core.validation.request.networkNotEnabled')];
       const error = new BitcoinProviderError(BitcoinProviderErrorType.INVALID_PARAMS, message, undefined, name);
 
-      console.error(error);
+      logicValidationLogger.error('Validation error: network not enabled for bitcoin transaction', error);
       errors.push(error);
     } else {
       handleError(message);

packages/extension-base/src/core/utils.ts

@@ -16,6 +16,10 @@ import { getBitcoinAddressInfo, validateBitcoinAddress } from '@subwallet/keyrin
 import { AnyJson } from '@polkadot/types/types';
 import { isEthereumAddress } from '@polkadot/util-crypto';
 
+import { createLogger } from '@subwallet/extension-base/utils/logger';
+
+const coreUtilsLogger = createLogger('CoreUtils');
+
 export function getStrictMode (type: string, extrinsicType?: ExtrinsicType) {
   if (type === BalanceAccountType.FrameSystemAccountInfo) {
     return !extrinsicType || ![ExtrinsicType.TRANSFER_BALANCE].includes(extrinsicType);
@@ -235,7 +239,7 @@ export const _isSufficientToken = async (tokenInfo: _ChainAsset, substrateApi: _
         }
       }
     } catch (e) {
-      console.error(e);
+      coreUtilsLogger.error('Error in core utils', e);
     }
   }
 

packages/extension-base/src/koni/api/coingecko.ts

@@ -3,8 +3,11 @@
 
 import { CurrencyJson, CurrencyType, ExchangeRateJSON, PriceJson } from '@subwallet/extension-base/background/KoniTypes';
 import { staticData, StaticKey } from '@subwallet/extension-base/utils/staticData';
+import { createLogger } from '@subwallet/extension-base/utils/logger';
 import axios, { AxiosResponse } from 'axios';
 
+const coingeckoLogger = createLogger('Coingecko');
+
 interface GeckoItem {
   id: string,
   name: string,
@@ -46,7 +49,7 @@ export const getTokenPrice = async (priceIds: Set<string>, currencyCode: Currenc
       }
 
       if (rs?.status !== 200) {
-        console.warn('Failed to get token price');
+        coingeckoLogger.warn('Failed to get token price');
       }
 
       return rs;
@@ -58,11 +61,11 @@ export const getTokenPrice = async (priceIds: Set<string>, currencyCode: Currenc
       try {
         rs = await axios.get('https://api-cache.subwallet.app/exchange-rate');
       } catch (e) {
-        console.warn('Failed to get exchange rate');
+        coingeckoLogger.warn('Failed to get exchange rate', e);
       }
 
       if (rs?.status !== 200) {
-        console.warn('Failed to get exchange rate');
+        coingeckoLogger.warn('Failed to get exchange rate - invalid status');
       }
 
       return rs;
@@ -109,7 +112,7 @@ export const getTokenPrice = async (priceIds: Set<string>, currencyCode: Currenc
       price24hMap
     } as PriceJson;
   } catch (err) {
-    console.error(err);
+    coingeckoLogger.error('Error fetching price data', err);
     throw err;
   }
 };

packages/extension-base/src/koni/api/dotsama/crowdloan.ts

@@ -9,8 +9,11 @@ import registry from '@subwallet/extension-base/koni/api/dotsama/typeRegistry';
 import { _SubstrateApi } from '@subwallet/extension-base/services/chain-service/types';
 import { fetchJson, getAddressesByChainType, reformatAddress } from '@subwallet/extension-base/utils';
 import { fetchStaticData } from '@subwallet/extension-base/utils/fetchStaticData';
+import { createLogger } from '@subwallet/extension-base/utils/logger';
 
 import { DeriveOwnContributions } from '@polkadot/api-derive/types';
+
+const crowdloanLogger = createLogger('Crowdloan');
 import { BN } from '@polkadot/util';
 
 const STATUS_MAP: Record<_FundStatus, CrowdloanParaState> = {
@@ -74,7 +77,7 @@ function getRPCCrowdloan (parentAPI: _SubstrateApi, fundInfo: _CrowdloanFund, he
       .then((unsub) => {
         unsub();
       })
-      .catch(console.error);
+      .catch((e) => crowdloanLogger.error('Error unsubscribing from crowdloan', e));
   };
 }
 
@@ -109,7 +112,7 @@ export const subscribeAcalaContributeInterval = (polkadotAddresses: string[], fu
       };
 
       callback(rs);
-    }).catch(console.error);
+    }).catch((e) => crowdloanLogger.error('Error fetching Acala contribution info', e));
   };
 
   getContributeInfo();

packages/extension-base/src/koni/api/dotsama/domain.ts

@@ -5,6 +5,10 @@ import { resolveAddressToDomain, resolveDomainToAddress, SupportedChainId } from
 
 import { ApiPromise } from '@polkadot/api';
 
+import { createLogger } from '@subwallet/extension-base/utils/logger';
+
+const domainResolverLogger = createLogger('DomainResolver');
+
 export const ENS_SUFFIX = '.eth';
 export const TZERO_ID_SUFFIX = '.tzero';
 
@@ -42,7 +46,7 @@ export async function resolveAzeroDomainToAddress (domain: string, chain: string
   );
 
   if (primaryDomains.error) {
-    console.debug(primaryDomains.error);
+    domainResolverLogger.debug('Error resolving domain to address', primaryDomains.error);
   }
 
   return primaryDomains?.address || undefined;
@@ -64,7 +68,7 @@ export async function resolveAzeroAddressToDomain (address: string, chain: strin
   );
 
   if (primaryDomains.error) {
-    console.debug(primaryDomains.error);
+    domainResolverLogger.debug('Error resolving address to domain', primaryDomains.error);
   }
 
   return primaryDomains?.primaryDomain || undefined;

packages/extension-base/src/koni/api/nft/acala_nft/index.ts

@@ -6,6 +6,9 @@ import { getRandomIpfsGateway } from '@subwallet/extension-base/koni/api/nft/con
 import { BaseNftApi, HandleNftParams } from '@subwallet/extension-base/koni/api/nft/nft';
 import { _SubstrateApi } from '@subwallet/extension-base/services/chain-service/types';
 import { isUrl } from '@subwallet/extension-base/utils';
+import { createLogger } from '@subwallet/extension-base/utils/logger';
+
+const acalaNftLogger = createLogger('AcalaNft');
 
 interface AssetId {
   classId: string | number,
@@ -157,7 +160,7 @@ export class AcalaNftApi extends BaseNftApi {
         params.updateCollection(this.chain, parsedCollection);
       }));
     } catch (e) {
-      console.error(`${this.chain}`, e);
+      acalaNftLogger.error(`Error handling NFTs for chain ${this.chain}`, e);
     }
   }
 

packages/extension-base/src/koni/api/nft/assethub_nft/index.ts

@@ -5,6 +5,9 @@ import { AssetHubNftType, NftCollection, NftItem } from '@subwallet/extension-ba
 import { BaseNftApi, HandleNftParams } from '@subwallet/extension-base/koni/api/nft/nft';
 import { _SubstrateApi } from '@subwallet/extension-base/services/chain-service/types';
 import { isUrl } from '@subwallet/extension-base/utils';
+import { createLogger } from '@subwallet/extension-base/utils/logger';
+
+const assethubNftLogger = createLogger('AssethubNft');
 
 interface AssetId {
   classId: string | number,
@@ -199,7 +202,7 @@ export default class AssetHubNftsPalletApi extends BaseNftApi {
         params.updateCollection(this.chain, parsedCollection);
       }));
     } catch (e) {
-      console.error(`${this.chain}`, e);
+      assethubNftLogger.error(`Error handling NFTs for chain ${this.chain}`, e);
     }
   }
 

packages/extension-base/src/koni/api/nft/assethub_unique/index.ts

@@ -5,6 +5,9 @@ import { AssetHubNftType, NftCollection, NftItem } from '@subwallet/extension-ba
 import { BaseNftApi, HandleNftParams } from '@subwallet/extension-base/koni/api/nft/nft';
 import { _SubstrateApi } from '@subwallet/extension-base/services/chain-service/types';
 import { isUrl } from '@subwallet/extension-base/utils';
+import { createLogger } from '@subwallet/extension-base/utils/logger';
+
+const assethubUniqueLogger = createLogger('AssethubUnique');
 
 interface AssetId {
   classId: string | number,
@@ -167,7 +170,7 @@ export default class AssetHubUniquesPalletApi extends BaseNftApi {
         params.updateCollection(this.chain, parsedCollection);
       }));
     } catch (e) {
-      console.error(`${this.chain}`, e);
+      assethubUniqueLogger.error(`Error handling NFTs for chain ${this.chain}`, e);
     }
   }
 

packages/extension-base/src/koni/api/nft/bit.country/index.ts

@@ -6,9 +6,12 @@ import { BIT_AVATAR_API, BIT_COUNTRY_IPFS_SERVER, BIT_COUNTRY_LAND_ESTATE_METADA
 import { BaseNftApi, HandleNftParams } from '@subwallet/extension-base/koni/api/nft/nft';
 import { _SubstrateApi } from '@subwallet/extension-base/services/chain-service/types';
 import { isUrl } from '@subwallet/extension-base/utils';
+import { createLogger } from '@subwallet/extension-base/utils/logger';
 
 import { BN_ZERO, hexToBn } from '@polkadot/util';
 
+const bitCountryNftLogger = createLogger('BitCountryNft');
+
 interface AssetId {
   classId: string | number,
   tokenId: string | number,
@@ -126,7 +129,7 @@ export class BitCountryNftApi extends BaseNftApi {
       try {
         metaverseId = hexToBn(hexMetaverseId);
       } catch (e) {
-        console.warn('Error parsing metaverse id', e);
+        bitCountryNftLogger.warn('Error parsing metaverse id', e);
       }
 
       return {
@@ -217,7 +220,7 @@ export class BitCountryNftApi extends BaseNftApi {
         params.updateCollection(this.chain, parsedCollection);
       }));
     } catch (e) {
-      console.error(`${this.chain}`, e);
+      bitCountryNftLogger.error(`Error handling NFTs for chain ${this.chain}`, e);
     }
   }
 

packages/extension-base/src/koni/api/nft/blobinscription/index.ts

@@ -6,9 +6,12 @@ import { COLLECT_ID } from '@subwallet/extension-base/koni/api/nft/blobinscripti
 import { ALC, getNftDetail, NftResponse, RemarkData, transferPayload } from '@subwallet/extension-base/koni/api/nft/blobinscription/types';
 import { AVAIL_LIGHT_CLIENT_NFT } from '@subwallet/extension-base/koni/api/nft/config';
 import { BaseNftApi, HandleNftParams } from '@subwallet/extension-base/koni/api/nft/nft';
+import { createLogger } from '@subwallet/extension-base/utils/logger';
 
 import { hexToString } from '@polkadot/util';
 
+const blobInscriptionLogger = createLogger('BlobInscription');
+
 export class BlobInscriptionApi extends BaseNftApi {
   endpoint = AVAIL_LIGHT_CLIENT_NFT;
 
@@ -162,7 +165,7 @@ export class BlobInscriptionApi extends BaseNftApi {
         }
       }));
     } catch (error) {
-      console.error('Failed to fetch blob inscription', error);
+      blobInscriptionLogger.error('Failed to fetch blob inscription', error);
     }
   }