Skip to content

Conversation

@lonelyicer
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 3, 2025 15:01
@github-actions github-actions bot added the enhancement New feature or request label Dec 3, 2025
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Game Test Results

✅ Success

Metric Value
Total Tests 1
Passed 1
Failed 0
Duration 646.0 ms

Workflow run: #276

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request implements a custom Abyss Trial Spawner system that mimics Minecraft's trial spawner behavior with configurable spawn patterns. The implementation includes a data-driven approach for defining entity spawns and loot rewards.

Key Changes

  • Added AbyssTrialSpawner core system with state machine for spawn cycles (inactive → waiting → active → rewarding → cooldown)
  • Implemented data provider and manager for trial spawner patterns using JSON configuration files
  • Modified block entity to use custom spawner logic instead of vanilla TrialSpawner
  • Fixed blockstate model mappings for WAITING_FOR_REWARD_EJECTION state

Reviewed changes

Copilot reviewed 14 out of 21 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
MiaUtil.java Added parseResourcePath() utility to extract path components from resource locations
MiaTrialSpawnerProvider.java Data provider with example trial spawner configurations (zombie, skeleton, spider, boss patterns)
AbyssTrialSpawnerDataProvider.java Abstract data provider base class for generating trial spawner JSON files
DataGenerators.java Registered trial spawner data provider for data generation
LootTableInstance.java Record for weighted loot table entries in spawn patterns
EntityTableInstance.java Record for weighted entity entries in spawn patterns
AbyssTrialSpawnerPattern.java Record defining complete spawn pattern configuration
AbyssTrialSpawnerManager.java Resource reload listener that loads spawn patterns from JSON
AbyssTrialSpawner.java Core spawner logic with state machine, mob tracking, and reward ejection
AbyssSpawnerBlockEntity.java Block entity implementation with pattern ID management and state access
AbyssSpawnerBlock.java Updated tooltip to display pattern ID from block entity data
CurseManager.java Refactored to use new parseResourcePath() utility and added @NotNull annotations
MIA.java Added spawner manager singleton and registered it as reload listener
MiaStateProvider.java Fixed blockstate model for WAITING_FOR_REWARD_EJECTION state
Generated JSON files Trial spawner pattern definitions and corrected advancement unlock conditions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lonelyicer
Copy link
Member Author

@copilot open a new pull request to apply changes based on the comments in this thread

Copy link
Contributor

Copilot AI commented Dec 3, 2025

@lonelyicer I've opened a new pull request, #75, to work on those changes. Once the pull request is ready, I'll request review from you.

@lonelyicer lonelyicer enabled auto-merge December 3, 2025 15:21
@lonelyicer lonelyicer merged commit f7ee5ec into main Dec 3, 2025
3 checks passed
@lonelyicer lonelyicer deleted the feat/abyss-trial-spawner branch December 3, 2025 15:29
@lonelyicer lonelyicer linked an issue Dec 6, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Abyss Trial Spawner

2 participants