Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 3, 2025

Addresses three code quality issues from parent PR review comments:

Resource Management

  • Wrapped InputStreamReader in try-with-resources in AbyssTrialSpawnerManager.java to prevent resource leak

Bounds Validation

  • Added length check in MiaUtil.parseResourcePath() before substring operation to prevent StringIndexOutOfBoundsException when filePath.length() == basePath.length()
// Before: Would throw on equal-length paths
var trimmedPath = filePath.substring(basePath.length() + 1);

// After: Returns null safely
if (filePath.length() <= basePath.length()) {
    return null;
}
var trimmedPath = filePath.substring(basePath.length() + 1);

Interface Compliance

  • Added @Override annotations to StateAccessor interface implementations in AbyssSpawnerBlockEntity.java (getPatternId(), getPattern(), hasValidPattern())

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@lonelyicer lonelyicer marked this pull request as ready for review December 3, 2025 15:18
@lonelyicer
Copy link
Member

@copilot ready for review

@lonelyicer lonelyicer changed the title [WIP] Implement custom abyss trial spawner system fix: some issues Dec 3, 2025
@lonelyicer lonelyicer merged commit 2bfb742 into feat/abyss-trial-spawner Dec 3, 2025
2 checks passed
Copy link
Contributor Author

Copilot AI commented Dec 3, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • maven.neoforged.net
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx1G -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)
  • mirrors.cloud.tencent.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -Xmx64m -Xms64m -Dorg.gradle.appname=gradlew -classpath /home/REDACTED/work/Made-In-Abyss/Made-In-Abyss/gradle/wrapper/gradle-wrapper.jar org.gradle.wrapper.GradleWrapperMain build --no-daemon (dns block)
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -Xmx64m -Xms64m -Dorg.gradle.appname=gradlew -classpath /home/REDACTED/work/Made-In-Abyss/Made-In-Abyss/gradle/wrapper/gradle-wrapper.jar org.gradle.wrapper.GradleWrapperMain --info -Dorg.gradle.configureondemand=false -Dorg.gradle.configuration-cache.problems=warn -Dorg.gradle.dependency.verification=off -Dorg.gradle.warning.mode=none --no-daemon --init-script /opt/hostedtoolcache/CodeQL/2.23.3/x64/codeql/java/tools/setup-proxy.gradle --init-script /opt/hostedtoolcache/CodeQL/2.23.3/x64/codeql/java/tools/dep-graph.gradle ForceDependencyResolutionPlugin_resolveAllDependencies --stacktrace -DGITHUB_DEPENDENCY_GRAPH_JOB_CORRELATOR=dep-graph (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title fix: some issues Fix resource leaks, bounds checks, and missing @Override annotations Dec 3, 2025
@lonelyicer lonelyicer deleted the copilot/sub-pr-74 branch December 3, 2025 15:20
Copilot AI requested a review from lonelyicer December 3, 2025 15:20
@lonelyicer lonelyicer linked an issue Dec 6, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Abyss Trial Spawner

2 participants