Feature: Advanced Character Builder Phase One - Life Path Builder#7625
Draft
IllianiBird wants to merge 165 commits into
Draft
Feature: Advanced Character Builder Phase One - Life Path Builder#7625IllianiBird wants to merge 165 commits into
IllianiBird wants to merge 165 commits into
Conversation
# Conflicts: # MekHQ/src/mekhq/campaign/Campaign.java # MekHQ/src/mekhq/campaign/CampaignConfiguration.java
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
# Conflicts: # MekHQ/resources/mekhq/resources/GUI.properties # MekHQ/resources/mekhq/resources/ImmersiveDialogConfirmation.properties # MekHQ/src/mekhq/MHQConstants.java # MekHQ/src/mekhq/gui/dialog/MHQOptionsDialog.java
# Conflicts: # MekHQ/build.gradle # MekHQ/src/mekhq/campaign/Campaign.java # MekHQ/src/mekhq/campaign/CampaignFactory.java # MekHQ/src/mekhq/campaign/personnel/advancedCharacterBuilder/LifePathEntryData.java # MekHQ/src/mekhq/campaign/personnel/skills/enums/SkillSubType.java
Collaborator
Author
|
Updated to match |
Collaborator
Author
|
Whoops, accidentally closed the PR D: |
Comment on lines
+218
to
+219
| LOGGER.error(ex, "Invalid default value for attribute {}: {} vs {}-{}", label, defaultValue, minValue, | ||
| maxValue); |
Check warning
Code scanning / CodeQL
Unused format argument Warning
|
|
||
| if (selectedCategoryCounts.containsKey(category)) { | ||
| int currentValue = selectedCategoryCounts.get(category); | ||
| currentValue = clamp(currentValue, minimumSkillLevel, maximumSkillLevel); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| // Normal Skills | ||
| for (String skillName : new ArrayList<>(allSkills)) { | ||
| SkillType type = SkillType.getType(skillName); | ||
| if (type.isCombatSkill()) { |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
# Conflicts: # MekHQ/resources/mekhq/resources/GUI.properties # MekHQ/resources/mekhq/resources/ImmersiveDialogConfirmation.properties # MekHQ/src/mekhq/MHQConstants.java # MekHQ/src/mekhq/campaign/Campaign.java # MekHQ/src/mekhq/gui/dialog/MHQOptionsDialog.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the first phase of the upcoming Advanced Character Builder (ACB). Specifically, this PR introduces the ability for users and developers to write, load, and customize their own Life Paths.
These Life Paths will be used by ACB to construct ATOW-style characters with rich backgrounds and diverse skills.
The Life Path Builder can be accessed here:
This PR is still WIP and is being posted solely so @HammerGS can have a play - he's been waiting very patiently.