Made Attribute Score Modifiers Clear in Personnel Table#8993
Open
IllianiBird wants to merge 2 commits into
Open
Made Attribute Score Modifiers Clear in Personnel Table#8993IllianiBird wants to merge 2 commits into
IllianiBird wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8993 +/- ##
============================================
+ Coverage 14.00% 14.09% +0.08%
- Complexity 8320 8343 +23
============================================
Files 1285 1285
Lines 167958 168048 +90
Branches 25418 25429 +11
============================================
+ Hits 23530 23687 +157
+ Misses 141950 141873 -77
- Partials 2478 2488 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HammerGS
approved these changes
May 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Improves clarity of ATOW attribute values shown in the Personnel table by including the derived attribute modifier alongside the current/cap display.
Changes:
- Refactors several attribute column renderings (STR/BOD/REF/DEX/INT/WIL/CHA) to use a shared formatter that includes the computed modifier.
- Introduces
Person#getAttributeModifier(SkillAttribute)as a convenience wrapper around the underlying ATOW attribute logic.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| MekHQ/src/mekhq/gui/enums/PersonnelTableModelColumn.java | Adds a helper to format attribute score/cap plus modifier and routes multiple columns through it. |
| MekHQ/src/mekhq/campaign/personnel/Person.java | Adds a new public method to retrieve a person’s attribute modifier for a given attribute. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We received feedback that the current Attribute Score display, in the personnel tab, wasn't very clear. As, unless you already knew the ATOW scores by heart, it was difficult to spot the actual modifiers these attributes provided.
I went in and added the attribute modifier to the display: