Skip to content

Made Attribute Score Modifiers Clear in Personnel Table#8993

Open
IllianiBird wants to merge 2 commits into
MegaMek:mainfrom
IllianiBird:ClearerAttributeScoreModifiers
Open

Made Attribute Score Modifiers Clear in Personnel Table#8993
IllianiBird wants to merge 2 commits into
MegaMek:mainfrom
IllianiBird:ClearerAttributeScoreModifiers

Conversation

@IllianiBird
Copy link
Copy Markdown
Collaborator

We received feedback that the current Attribute Score display, in the personnel tab, wasn't very clear. As, unless you already knew the ATOW scores by heart, it was difficult to spot the actual modifiers these attributes provided.

I went in and added the attribute modifier to the display:

image

@IllianiBird IllianiBird self-assigned this May 18, 2026
@IllianiBird IllianiBird requested a review from a team as a code owner May 18, 2026 01:03
@IllianiBird IllianiBird added Personnel Personnel-related Issues GUI UX User experience labels May 18, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 14.09%. Comparing base (d2c8380) to head (7d58dfd).
⚠️ Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
...src/mekhq/gui/enums/PersonnelTableModelColumn.java 0.00% 14 Missing ⚠️
MekHQ/src/mekhq/campaign/personnel/Person.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8993      +/-   ##
============================================
+ Coverage     14.00%   14.09%   +0.08%     
- Complexity     8320     8343      +23     
============================================
  Files          1285     1285              
  Lines        167958   168048      +90     
  Branches      25418    25429      +11     
============================================
+ Hits          23530    23687     +157     
+ Misses       141950   141873      -77     
- Partials       2478     2488      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread MekHQ/src/mekhq/gui/enums/PersonnelTableModelColumn.java Fixed
@HammerGS HammerGS requested a review from Copilot May 18, 2026 15:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves clarity of ATOW attribute values shown in the Personnel table by including the derived attribute modifier alongside the current/cap display.

Changes:

  • Refactors several attribute column renderings (STR/BOD/REF/DEX/INT/WIL/CHA) to use a shared formatter that includes the computed modifier.
  • Introduces Person#getAttributeModifier(SkillAttribute) as a convenience wrapper around the underlying ATOW attribute logic.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
MekHQ/src/mekhq/gui/enums/PersonnelTableModelColumn.java Adds a helper to format attribute score/cap plus modifier and routes multiple columns through it.
MekHQ/src/mekhq/campaign/personnel/Person.java Adds a new public method to retrieve a person’s attribute modifier for a given attribute.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread MekHQ/src/mekhq/gui/enums/PersonnelTableModelColumn.java Outdated
Comment thread MekHQ/src/mekhq/gui/enums/PersonnelTableModelColumn.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GUI Personnel Personnel-related Issues UX User experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants