Close #8625, #8804: Added Options to Quick Train (Both Manual & Automatically Run) to Allow Players to Adjust What Skills are Trained and to What Level#9096
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #9096 +/- ##
============================================
- Coverage 15.23% 15.22% -0.01%
- Complexity 9305 9319 +14
============================================
Files 1304 1304
Lines 172518 172662 +144
Branches 26063 26061 -2
============================================
+ Hits 26277 26287 +10
- Misses 143198 143328 +130
- Partials 3043 3047 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sleet01
reviewed
May 25, 2026
Comment on lines
+299
to
+303
| boolean isDoctorsUseAdministration, boolean isTechsUseAdministration, boolean isLevelArtillery, | ||
| boolean isUseSmallArmsOnly, boolean isLevelScoutingSkills, boolean isLevelEscapeSkills, | ||
| boolean isUseAppraisal, ProcurementPersonnelPick procurementPersonnel, boolean isLevelLeadership, | ||
| boolean isLevelTraining, boolean isLevelOtherCommandSkills, List<String> targetSkills, | ||
| SkillModifierData skillModifierData) { |
Collaborator
There was a problem hiding this comment.
We should probably consider a record or something, instead of continuing to expand this list.
Please take a look the next time we touch this function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #8625
Close #8804
As per title. These changes have resulted in both changes to Quick Train run from the Personnel tab, and to MekHQ Client Options (New Day options).