Skip to content

Fix #8661: Fix Temp crew feedback when not possible#9097

Merged
psikomonkie merged 4 commits into
MegaMek:mainfrom
psikomonkie:issue/8661/temp-crew-feedback
May 26, 2026
Merged

Fix #8661: Fix Temp crew feedback when not possible#9097
psikomonkie merged 4 commits into
MegaMek:mainfrom
psikomonkie:issue/8661/temp-crew-feedback

Conversation

@psikomonkie
Copy link
Copy Markdown
Member

Fixes #8661

Disables temp pool buttons that do nothing and adds a tooltip with the reason.

The temp crew submenus share some common methods for checking crews.

@psikomonkie psikomonkie requested a review from a team as a code owner May 25, 2026 21:07
@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

❌ Patch coverage is 0% with 191 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.21%. Comparing base (71e0df4) to head (295b496).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
MekHQ/src/mekhq/gui/CampaignGUI.java 0.00% 162 Missing ⚠️
...Q/src/mekhq/gui/adapter/UnitTableMouseAdapter.java 0.00% 29 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9097      +/-   ##
============================================
+ Coverage     15.18%   15.21%   +0.03%     
- Complexity     9332     9344      +12     
============================================
  Files          1308     1308              
  Lines        173519   173416     -103     
  Branches      26202    26220      +18     
============================================
+ Hits          26349    26388      +39     
+ Misses       144098   143961     -137     
+ Partials       3072     3067       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IllianiBird
Copy link
Copy Markdown
Collaborator

Conflicts :(

# Conflicts:
#	MekHQ/resources/mekhq/resources/GUI.properties
@psikomonkie psikomonkie merged commit bb301d5 into MegaMek:main May 26, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Issue] Temp crew hiring should have a feedback when not possible

3 participants