PR: MekHQ Client Options to not fire surplus temp personnel on new day#9099
Merged
IllianiBird merged 1 commit intoMay 26, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #9099 +/- ##
============================================
- Coverage 15.23% 15.18% -0.05%
Complexity 9305 9305
============================================
Files 1304 1305 +1
Lines 172518 173071 +553
Branches 26063 26146 +83
============================================
+ Hits 26277 26278 +1
- Misses 143198 143752 +554
+ Partials 3043 3041 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sleet01
reviewed
May 25, 2026
| chkNewDayVesselCrewPoolFill.text=Fill Vessel Crew Pool | ||
| chkNewDayVesselCrewPoolFill.toolTipText=Automatically fill the Vessel Crew pool immediately upon selecting new day,\ | ||
| \ and distribute to vessel units. | ||
| chkNewDayAstechPoolNoRelease.text=└ Do Not Release Surplus Astechs |
Collaborator
There was a problem hiding this comment.
Is this really the cleanest way to mark dependent checkboxes?
Just when I thought my opinion of AWT/Swing couldn't get any lower -_-;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MekHQ client options for hiring temp personnel on a new day always technically reset the temp personnel - it would fire surplus.
When mothballing units with temp crew, the temp crew will be fired if "fill temp crew on new day" is enabled.
This adds a setting for each option to not fire surplus personnel but still hire to get past any shortfalls and auto assign to units.