Fix #8735: Added Instant MRMS Button Back to Command Center#9103
Open
IllianiBird wants to merge 1 commit into
Open
Fix #8735: Added Instant MRMS Button Back to Command Center#9103IllianiBird wants to merge 1 commit into
IllianiBird wants to merge 1 commit into
Conversation
IllianiBird
added
Bug
Mass Repair/Mass Salvage
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #9103 +/- ##
============================================
+ Coverage 15.18% 15.19% +0.01%
- Complexity 9305 9340 +35
============================================
Files 1305 1308 +3
Lines 173071 173539 +468
Branches 26146 26202 +56
============================================
+ Hits 26278 26377 +99
- Misses 143752 144094 +342
- Partials 3041 3068 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8735
We used to have an option that would cause an MRMS button to be available in the command center. At some point, I have no idea when, it got deleted. Not sure why, not super important. The weird thing is that the MekHQ client option was left in place, as well as all its hookups. Super weird.
Anyhoo, I think it's important we don't hide GUI elements behind client options most players won't be aware of. Rather than restoring the original option I went ahead and ripped out the option code and now the button will always be visible.
The area where it lives was previously labeled 'procurement information', as that was no longer accurate I went ahead and removed the label. This has the added benefit of allowing us to place non-procurement stuff there, moving forward.