Skip to content

Fix #8729: Fixed Routed OpFors Generating Scenarios Despite Having No Forces to Fight Them#9104

Open
IllianiBird wants to merge 1 commit into
MegaMek:mainfrom
IllianiBird:routedOpForScenarioIssue
Open

Fix #8729: Fixed Routed OpFors Generating Scenarios Despite Having No Forces to Fight Them#9104
IllianiBird wants to merge 1 commit into
MegaMek:mainfrom
IllianiBird:routedOpForScenarioIssue

Conversation

@IllianiBird
Copy link
Copy Markdown
Collaborator

Fix #8729

This was caused by an oversight in how we scheduled and then executed scenario generation. If the OpFor routed before a scheduled scenario's date, that scenario would still go ahead. Now we discard the scheduled scenario entirely.

@IllianiBird IllianiBird self-assigned this May 26, 2026
@IllianiBird IllianiBird requested a review from a team as a code owner May 26, 2026 05:03
@IllianiBird IllianiBird added Bug StratCon Bugs relating strictly to StratCon Severity: Medium Issues described as medium severity as per the new issue form labels May 26, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.20%. Comparing base (71e0df4) to head (9802518).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../mekhq/campaign/stratCon/StratConRulesManager.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9104      +/-   ##
============================================
+ Coverage     15.18%   15.20%   +0.01%     
- Complexity     9332     9335       +3     
============================================
  Files          1308     1308              
  Lines        173519   173520       +1     
  Branches      26202    26203       +1     
============================================
+ Hits          26349    26383      +34     
+ Misses       144098   144060      -38     
- Partials       3072     3077       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Severity: Medium Issues described as medium severity as per the new issue form StratCon Bugs relating strictly to StratCon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Issue] [0.50.12-nightly-2026-02-02] The Routed enemy continues to generate scenarios

1 participant