Fix #8729: Fixed Routed OpFors Generating Scenarios Despite Having No Forces to Fight Them#9104
Open
IllianiBird wants to merge 1 commit into
Open
Fix #8729: Fixed Routed OpFors Generating Scenarios Despite Having No Forces to Fight Them#9104IllianiBird wants to merge 1 commit into
IllianiBird wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9104 +/- ##
============================================
+ Coverage 15.18% 15.20% +0.01%
- Complexity 9332 9335 +3
============================================
Files 1308 1308
Lines 173519 173520 +1
Branches 26202 26203 +1
============================================
+ Hits 26349 26383 +34
+ Misses 144098 144060 -38
- Partials 3072 3077 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8729
This was caused by an oversight in how we scheduled and then executed scenario generation. If the OpFor routed before a scheduled scenario's date, that scenario would still go ahead. Now we discard the scheduled scenario entirely.