Fix #5722, #7438: Added New Repair GM Option to Instantly Acquire Required Part and GM Repair#9108
Fix #5722, #7438: Added New Repair GM Option to Instantly Acquire Required Part and GM Repair#9108IllianiBird wants to merge 5 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9108 +/- ##
=========================================
Coverage 15.20% 15.20%
- Complexity 9335 9340 +5
=========================================
Files 1311 1312 +1
Lines 173407 173465 +58
Branches 26220 26223 +3
=========================================
+ Hits 26372 26381 +9
- Misses 143957 144011 +54
+ Partials 3078 3073 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| gui.getCampaign() | ||
| .addReport(TECHNICAL, String.format("GM Repair, %s %s", p.getPartName(), p.succeed())); |
There was a problem hiding this comment.
Should this be above at line 160?
It looks like this function may be called by non-GM fixes as well as GM fixes.
There was a problem hiding this comment.
Yeah, this seems like an odd place... also lots of single letter variable names...
Smells like something I intended to clean up later and forgot
Sleet01
left a comment
There was a problem hiding this comment.
I'm not clear if the reporting about GM fixes is actually needed every time the function is called, but if so then it should be fine.
There were issues with this PR, since corrected, but this wasn't one of them. This whole chunk of methods is only called within the context of GM repair. Non-GM repair isn't handled by the context menu but a dedicated button. |
Fix #5722
Fix #7438
When players GM repair a task (such as damaged items), if the player doesn't have the replacement part, the task would report it was successful. However, the task would never actually be performed.
This PR adds a new option to GM repair a task and, at the same time, magically procure it via GM acquisition.
Is god darned task took three frickin' hours. Why? Why are Parts such problem children!?