Skip to content

Unify recruitment-related vocabulary in the UI#9117

Merged
IllianiBird merged 2 commits into
MegaMek:mainfrom
hokvel:location-panel
May 27, 2026
Merged

Unify recruitment-related vocabulary in the UI#9117
IllianiBird merged 2 commits into
MegaMek:mainfrom
hokvel:location-panel

Conversation

@hokvel
Copy link
Copy Markdown
Contributor

@hokvel hokvel commented May 27, 2026

Additionally includes some docs / name changes in the code.

Additionally includes some docs / name changes in the code too.
@hokvel hokvel requested a review from a team as a code owner May 27, 2026 16:23
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

❌ Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.22%. Comparing base (a1be97c) to head (916f4fa).
⚠️ Report is 82 commits behind head on main.

Files with missing lines Patch % Lines
MekHQ/src/mekhq/gui/CampaignGUI.java 0.00% 33 Missing ⚠️
MekHQ/src/mekhq/gui/view/CurrentLocationPanel.java 0.00% 4 Missing ⚠️
MekHQ/src/mekhq/campaign/Campaign.java 0.00% 1 Missing ⚠️
...ekHQ/src/mekhq/campaign/CampaignNewDayManager.java 0.00% 1 Missing ⚠️
MekHQ/src/mekhq/campaign/CurrentLocation.java 0.00% 1 Missing ⚠️
MekHQ/src/mekhq/gui/BriefingTab.java 0.00% 1 Missing ⚠️
MekHQ/src/mekhq/gui/ReportHyperlinkListener.java 0.00% 1 Missing ⚠️
...mekhq/gui/campaignOptions/contents/MarketsTab.java 0.00% 1 Missing ⚠️
MekHQ/src/mekhq/gui/dialog/DataLoadingDialog.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9117      +/-   ##
============================================
+ Coverage     15.21%   15.22%   +0.01%     
- Complexity     9343     9350       +7     
============================================
  Files          1308     1308              
  Lines        173420   173407      -13     
  Branches      26220    26217       -3     
============================================
+ Hits          26386    26404      +18     
+ Misses       143959   143928      -31     
  Partials       3075     3075              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@IllianiBird IllianiBird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some points of feedback that we probably wanna look at, before this is merged.

Comment thread MekHQ/resources/mekhq/resources/CampaignOptionsDialog.properties Outdated
Comment thread MekHQ/resources/mekhq/resources/CampaignOptionsDialog.properties Outdated
Comment thread MekHQ/resources/mekhq/resources/PersonnelMarket.properties Outdated
@IllianiBird IllianiBird merged commit bfc3811 into MegaMek:main May 27, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants