Skip to content

Close #9120: Stop Clan Characters Generating Melee SPAs Based on Era & Homeworld Clan Status#9121

Open
IllianiBird wants to merge 3 commits into
MegaMek:mainfrom
IllianiBird:homeworldMeleeBan
Open

Close #9120: Stop Clan Characters Generating Melee SPAs Based on Era & Homeworld Clan Status#9121
IllianiBird wants to merge 3 commits into
MegaMek:mainfrom
IllianiBird:homeworldMeleeBan

Conversation

@IllianiBird
Copy link
Copy Markdown
Collaborator

Close #9120

Clan characters can no longer receive the Melee Specialist or Melee Master SPAs, outside of player intervention.

The restriction follows the following conditions:

  • If before the Dark Ages, no Clan characters will receive these SPAs.
  • If after the Late Republic era, no Homeworld Clan characters will receive these SPAs but Inner Sphere Clan characters can.

This better brings out code in-line with canon.

@IllianiBird IllianiBird self-assigned this May 27, 2026
@IllianiBird IllianiBird requested a review from a team as a code owner May 27, 2026 18:16
@IllianiBird IllianiBird added Personnel Personnel-related Issues SPA Any issue relating to SPA's. Includes Bugs and RFE labels May 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

❌ Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.22%. Comparing base (f2bf383) to head (0da1b8e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...onnel/generator/SingleSpecialAbilityGenerator.java 0.00% 13 Missing ⚠️
MekHQ/src/mekhq/campaign/universe/Faction.java 0.00% 5 Missing ⚠️
MekHQ/src/mekhq/campaign/universe/eras/Eras.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9121      +/-   ##
============================================
+ Coverage     15.20%   15.22%   +0.01%     
- Complexity     9335     9345      +10     
============================================
  Files          1311     1311              
  Lines        173407   173430      +23     
  Branches      26220    26227       +7     
============================================
+ Hits          26372    26400      +28     
- Misses       143957   143963       +6     
+ Partials       3078     3067      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Personnel Personnel-related Issues SPA Any issue relating to SPA's. Includes Bugs and RFE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFE] Restrict Melee Specialist & Master for OpFor Clan pilots

2 participants