fix: replace computed Network enum initialisers with string literals - #101
Merged
Conversation
hmalik88
marked this pull request as ready for review
August 4, 2026 04:03
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
ccharly
approved these changes
Aug 4, 2026
ccharly
left a comment
ccharly
left a comment
Contributor
There was a problem hiding this comment.
We should really ban enum 🥹
hmalik88
enabled auto-merge
August 4, 2026 09:25
ulissesferreira
approved these changes
Aug 4, 2026
2 tasks
jeremytsng
pushed a commit
that referenced
this pull request
Aug 5, 2026
## Explanation This PR introduces transaction-history synchronization and richer Horizon-derived transaction mapping for the Stellar snap, including decoding result_xdr for more accurate path-payment (swap/receive) amounts and persisting per-account scan cursors. <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Networkenum members were initialised fromTrxScope.Mainnet / .Nile / .Shasta(a regular, non-const enum). TypeScript compiles any enum with computed initialisers using the bidirectional numeric-enum pattern, soObject.values(Network)returned 6 values: the 3 CAIP-2 scope IDs plus their reverse-mapped human-readable names ("Mainnet","Nile","Shasta").bip44:discoveriteratesObject.values(Network)to check on-chain activity on every scope. When it reached"Mainnet",checkAddressActivitycalledgetTransactionInfoByAddress("Mainnet", addr), which threw"No client configured for network: Mainnet", causingPromise.allto reject and every discovery attempt to silently return[].Object.values(Network)now returns only the 3 scope IDs.Test plan
yarn workspace @metamask/tron-wallet-snap run build— no type errorsyarn workspace @metamask/tron-wallet-snap run test— all tests passdiscovers Tron accounts through Account 5e2e test inmetamask-extensionand confirm it passesReferences
N/A
Checklist