Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [cherrypick][V12.3.0] Add approval static simulation (#26514) (2/3 permit simulation fix) #27187

Closed

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Sep 17, 2024

Description

Cherry-picking #26514 into V12.3.0

1 1-line import conflict resolved with no changes

2 of 2 prerequisites before cherry-picking #26684
prerequisite 1: #27186
prerequistite 2: (this PR) #27187

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26514?quickstart=1)

Fixes: MetaMask/MetaMask-planning#3010

1. Go to this page...
2.
3.

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

<!-- [screenshots/recordings] -->

<!-- [screenshots/recordings] -->

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@digiwand digiwand added the team-confirmations Push issues to confirmations team label Sep 17, 2024
@digiwand digiwand requested review from a team as code owners September 17, 2024 03:59
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@digiwand digiwand changed the title feat: Add approval static simulation (#26514) feat: [cherrypick][V12.3.0] Add approval static simulation (#26514) (2/3 permit simulation fix) Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.26%. Comparing base (a7d54fd) to head (62bec00).

Files with missing lines Patch % Lines
...ations/components/confirm/info/approve/approve.tsx 75.00% 3 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           cherrypick-12.3.0-pnf/2936   #27187   +/-   ##
===========================================================
  Coverage                       70.25%   70.26%           
===========================================================
  Files                            1429     1430    +1     
  Lines                           50285    50300   +15     
  Branches                        13970    13972    +2     
===========================================================
+ Hits                            35327    35339   +12     
- Misses                          14958    14961    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [62bec00]
Page Load Metrics (1656 ± 102 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint148923681664209100
domContentLoaded14382285161520096
load149223731656212102
domInteractive136432136

@digiwand
Copy link
Contributor Author

Thanks @pedronfigueiredo! update - will not merge into 12.3

@digiwand digiwand closed this Sep 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants