Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [cherrypick][V12.3.0] Redesign Approve confirmation (#26464) (1/3 permit simulation fix) #27186

Closed
wants to merge 1 commit into from
Closed

feat: [cherrypick][V12.3.0] Redesign Approve confirmation (#26464) (1/3 permit simulation fix) #27186

wants to merge 1 commit into from

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Sep 17, 2024 •
edited
Loading

Description

cherry-picks #26464 into V12.3.0

no conflicts

1 of 2 prerequisites before cherry-picking #26684
prerequisite 1: this PR
prerequistite 2: #27187

Implements redesigned confirmation screens for tokenMethodApprove
(ERC721 and ERC1155). Includes e2e and integration tests.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2936

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo @digiwand
feat: Redesign Approve confirmation (#26464)
a7d54fd 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Implements redesigned confirmation screens for `tokenMethodApprove`
(ERC721 and ERC1155). Includes e2e and integration tests.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26464?quickstart=1)

## **Related issues**

Fixes: MetaMask/MetaMask-planning#2936

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@digiwand digiwand requested review from a team as code owners September 17, 2024 03:52
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@digiwand digiwand added the team-confirmations Push issues to confirmations team label Sep 17, 2024
@digiwand digiwand mentioned this pull request Sep 17, 2024
Closed
7 tasks
@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.

Project coverage is 70.25%. Comparing base (439f7d6) to head (a7d54fd).
Report is 9 commits behind head on Version-v12.3.0.

Files with missing lines Patch % Lines
...s/confirmations/components/confirm/title/title.tsx 0.00% 4 Missing ⚠️
...m/info/approve/approve-details/approve-details.tsx 80.00% 3 Missing ⚠️
...ges/confirmations/components/confirm/info/info.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                 Coverage Diff                 @@
##           Version-v12.3.0   #27186      +/-   ##
===================================================
+ Coverage            70.24%   70.25%   +0.01%     
===================================================
  Files                 1426     1429       +3     
  Lines                50239    50285      +46     
  Branches             13954    13970      +16     
===================================================
+ Hits                 35289    35327      +38     
- Misses               14950    14958       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [a7d54fd]
Page Load Metrics (1840 ± 93 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22321871672473227
domContentLoaded15792359181218388
load16302451184019493
domInteractive148138178

@digiwand digiwand changed the title feat: Redesign Approve confirmation (#26464) feat: [cherrypick][V12.3.0] Redesign Approve confirmation (#26464) (1/3 permit simulation fix) Sep 17, 2024
This was referenced Sep 18, 2024
Closed
Open
danjm
danjm requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not merge

@digiwand
Copy link
Contributor Author

Thanks @pedronfigueiredo and @danjm! update - will not merge into 12.3

@digiwand digiwand closed this Sep 20, 2024
@digiwand digiwand deleted the cherrypick-12.3.0-pnf/2936 branch September 20, 2024 11:14
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danjm danjm danjm requested changes

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

Assignees
No one assigned
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@digiwand @metamaskbot @danjm @pedronfigueiredo