Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Clicking on false positive, Blockaid link does not add external_link_clicked to signature events #23995

Open
digiwand opened this issue Apr 12, 2024 · 3 comments · May be fixed by #29969
Open

[Bug]: Clicking on false positive, Blockaid link does not add external_link_clicked to signature events #23995

digiwand opened this issue Apr 12, 2024 · 3 comments · May be fixed by #29969
Assignees
@pnarayanaswamy
Labels
regression-prod-11.13.0 Regression bug that was found in production in release 11.13.0 Sev3-low Low severity; minimal to no impact upon users stale issues and PRs marked as stale team-confirmations Push issues to confirmations team type-bug

Comments

@digiwand
Copy link
Contributor

Describe the bug

Clicking to report a false positive security alerts triggers doesn't add external_link_clicked to the respective signature event. Only no-signature transactions.

Related to: https://github.com/MetaMask/MetaMask-planning/issues/1756
Discovered: #23555 (comment)
Example metric

Expected behavior

Clicking to report a false positive security alerts triggers doesn't add external_link_clicked to the respective transaction and signature events

Screenshots/Recordings

No response

Steps to reproduce

  1. Turn on Blockaid in Security Settings
  2. Go to test dapp
  3. Test PPOM buttons
  4. Observe reports

Error messages or log output

No response

Version

11.13.0

Build type

None

Browser

Chrome

Operating system

Windows

Hardware wallet

No response

Additional context

No response

Severity

No response
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Apr 12, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Apr 12, 2024
@digiwand digiwand changed the title [Bug]: Blockaid [Bug]: Clicking on false positive, Blockaid link does not add external_link_clicked to signature events Apr 12, 2024
@digiwand digiwand added the team-confirmations-secure-ux-PR PRs from the confirmations team label Apr 12, 2024
@metamaskbot metamaskbot added the regression-prod-11.13.0 Regression bug that was found in production in release 11.13.0 label Apr 12, 2024
@digiwand digiwand mentioned this issue Apr 12, 2024
Closed
@gauthierpetetin gauthierpetetin added team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead Sev3-low Low severity; minimal to no impact upon users team-confirmations-planning (only for internal use within Confirmations team) labels Apr 12, 2024
@cryptotavares cryptotavares added the team-confirmations Push issues to confirmations team label Apr 24, 2024
@bschorchit bschorchit removed the team-confirmations-planning (only for internal use within Confirmations team) label May 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Aug 27, 2024
@bschorchit bschorchit removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead team-confirmations-secure-ux-PR PRs from the confirmations team labels Sep 5, 2024
@github-actions github-actions bot removed the stale issues and PRs marked as stale label Sep 5, 2024
@jpuri jpuri assigned jpuri and unassigned jpuri Sep 13, 2024
@jpuri
Copy link
Contributor

jpuri commented Sep 13, 2024 •
edited
Loading

This issue will be much easier to address once this PR is merged #27043

@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Dec 12, 2024
@pnarayanaswamy pnarayanaswamy linked a pull request Jan 29, 2025 that will close this issue
Open
7 tasks
@pnarayanaswamy pnarayanaswamy self-assigned this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnarayanaswamy pnarayanaswamy

Labels
regression-prod-11.13.0 Regression bug that was found in production in release 11.13.0 Sev3-low Low severity; minimal to no impact upon users stale issues and PRs marked as stale team-confirmations Push issues to confirmations team type-bug
Projects
Bugs by severity
Status: To be fixed
Bugs by team
Status: To be fixed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Clicking on report link does not add external_link_clicked to si… MetaMask/metamask-extension
7 participants
@jpuri @gauthierpetetin @cryptotavares @digiwand @pnarayanaswamy @bschorchit @metamaskbot