Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1559 ledger #11951

Merged
merged 4 commits into from
Sep 1, 2021
Merged

1559 ledger #11951

merged 4 commits into from
Sep 1, 2021

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Aug 27, 2021

Fixes: Provides Ledger support for EIP-1559

Depends on:

How to Test

  • Check out this PR locally
  • Modify package.json to point to the commit from Fix 1559 eth-ledger-bridge-keyring#97, and run yarn setup
  • In the extension's node_modules/@metamask/eth-ledger-bridge-keyring/index.js file, change BRIDGE_URL to 'https://danjm.github.io/eth-ledger-bridge-keyring',

(Note that once the above dependencies are resolved, these testing steps will not be required)

@danjm danjm requested a review from a team as a code owner August 27, 2021 13:16
@danjm danjm requested a review from ryanml August 27, 2021 13:16
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [813b4ad]
Page Load Metrics (896 ± 72 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint5911784157
domContentLoaded619118789314871
load620118889614972
domInteractive619118689214871

@metamaskbot
Copy link
Collaborator

Builds ready [c668aa4]
Page Load Metrics (647 ± 29 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint52886394
domContentLoaded5307696455929
load5357766476029
domInteractive5307696455929

@adonesky1 adonesky1 requested review from ryanml and NiranjanaBinoy and removed request for ryanml August 31, 2021 18:21
@metamaskbot
Copy link
Collaborator

Builds ready [23e2e63]
Page Load Metrics (684 ± 28 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint559766105
domContentLoaded4947766835928
load4957776845928
domInteractive4947766825928

adonesky1
adonesky1 previously approved these changes Aug 31, 2021
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [750f4fa]
Page Load Metrics (741 ± 50 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint5510870126
domContentLoaded615108274010551
load616108374110550
domInteractive615108273910551

Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adonesky1 adonesky1 merged commit a4c0133 into develop Sep 1, 2021
@adonesky1 adonesky1 deleted the 1559-ledger branch September 1, 2021 16:25
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants