-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1559 ledger #11951
1559 ledger #11951
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [813b4ad]
Page Load Metrics (896 ± 72 ms)
|
Builds ready [c668aa4]
Page Load Metrics (647 ± 29 ms)
|
Builds ready [23e2e63]
Page Load Metrics (684 ± 28 ms)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Builds ready [750f4fa]
Page Load Metrics (741 ± 50 ms)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes: Provides Ledger support for EIP-1559
Depends on:
How to Test
yarn setup
node_modules/@metamask/eth-ledger-bridge-keyring/index.js
file, changeBRIDGE_URL
to'https://danjm.github.io/eth-ledger-bridge-keyring'
,(Note that once the above dependencies are resolved, these testing steps will not be required)