feat(NOTIFY-866): add account syncing #27060

mathieuartu · 2024-09-11T12:55:00Z

Description

This PR adds account syncing to MetaMask.
As part of profile syncing, with this new feature, users will be able to synchronize all of their accounts and accounts' names across all of their devices.

Related issues

Fixes:

NOTIFY-866

Manual testing steps

Log in with SRP
Activate profile syncing in preferences
Add new accounts and rename others
Using another browser, log in with SRP
Activate profile syncing in preferences
Watch the magic happen!

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-09-11T12:55:11Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-09-11T12:56:05Z

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source	CI
New author	npm/[email protected]	New Author: ralxz Previous Author: holgerd77	`yarn.lock`	🚫

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@SocketSecurity ignore npm/[email protected]

mathieuartu · 2024-09-11T14:15:40Z

@metamaskbot update-policies

metamaskbot · 2024-09-11T14:27:11Z

Policies updated

metamaskbot · 2024-09-12T12:36:17Z

Builds ready [3f71dd9]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1837 ± 101 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1532	2205	1836	210	101
		domContentLoaded	1500	2197	1810	205	98
		load	1532	2206	1837	211	101
		domInteractive	14	63	33	13	6

Bundle size diffs [🚀 Bundle size reduced!]

background: -24.12 KiB (-0.67%)
ui: 1.41 KiB (0.02%)
common: -1.93 KiB (-0.02%)

codecov · 2024-09-12T12:39:18Z

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.10%. Comparing base (1d686e2) to head (a7e9c2c).
Report is 2 commits behind head on develop.

Files with missing lines	Patch %	Lines
.../hooks/metamask-notifications/useProfileSyncing.ts	90.91%	2 Missing ⚠️
ui/store/actions.ts	71.43%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #27060      +/-   ##
===========================================
+ Coverage    70.09%   70.10%   +0.01%     
===========================================
  Files         1438     1438              
  Lines        49971    50001      +30     
  Branches     13989    13992       +3     
===========================================
+ Hits         35026    35052      +26     
- Misses       14945    14949       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-09-12T13:19:46Z

Builds ready [6fec4c5]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1890 ± 173 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	235	3116	1732	592	284
		domContentLoaded	1583	2967	1867	338	162
		load	1593	3127	1890	360	173
		domInteractive	15	123	37	24	11

Bundle size diffs [🚀 Bundle size reduced!]

background: -24.12 KiB (-0.67%)
ui: 1.47 KiB (0.02%)
common: -1.93 KiB (-0.02%)

metamaskbot · 2024-09-12T14:12:41Z

Builds ready [0a69a97]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2098 ± 114 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	309	2681	2001	451	217
		domContentLoaded	1614	2599	2067	236	113
		load	1625	2680	2098	238	114
		domInteractive	16	64	36	13	6

Bundle size diffs [🚀 Bundle size reduced!]

background: -24.12 KiB (-0.67%)
ui: 1.47 KiB (0.02%)
common: -1.93 KiB (-0.02%)

metamaskbot · 2024-09-12T17:19:51Z

Builds ready [09185ce]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1975 ± 123 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	258	2427	1692	638	306
		domContentLoaded	1569	2417	1954	251	121
		load	1623	2427	1975	257	123
		domInteractive	15	109	37	20	10

Bundle size diffs [🚀 Bundle size reduced!]

background: -24.12 KiB (-0.67%)
ui: 1.44 KiB (0.02%)
common: -1.93 KiB (-0.02%)

socket-security · 2024-09-18T10:26:16Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	None	`0`	266 kB	metamaskbot
npm/@metamask/[email protected]	None	`0`	59.7 kB	metamaskbot
npm/@metamask/[email protected]	None	`0`	42.4 kB	metamaskbot
npm/@metamask/[email protected]	None	`0`	537 kB	metamaskbot
npm/@noble/[email protected]	None	`0`	624 kB	paulmillr
npm/[email protected]	None	`0`	162 kB	ralxz
npm/[email protected]	None	`0`	11.2 kB	mathias

🚮 Removed packages: npm/@metamask/[email protected], npm/@noble/[email protected]

View full report↗︎

sonarcloud · 2024-09-18T10:27:49Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-09-19T10:41:28Z

Builds ready [bbdb18d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1863 ± 133 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1501	2719	1871	279	134
		domContentLoaded	1492	2706	1844	277	133
		load	1501	2717	1863	277	133
		domInteractive	13	197	62	49	24

Bundle size diffs [🚀 Bundle size reduced!]

background: -961 Bytes (-0.02%)
ui: 1.54 KiB (0.02%)
common: -16.97 KiB (-0.21%)

.yarn/patches/@metamask-keyring-controller-npm-17.1.1-098cb41930.patch

matteoscurati

LGTM

sonarcloud · 2024-09-19T13:06:05Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
79.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-09-19T13:25:12Z

Builds ready [0e01f8d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1852 ± 73 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	327	2328	1778	370	177
		domContentLoaded	1575	2170	1811	127	61
		load	1584	2264	1852	152	73
		domInteractive	23	83	43	17	8

Bundle size diffs [🚀 Bundle size reduced!]

background: -961 Bytes (-0.02%)
ui: 1.54 KiB (0.02%)
common: -16.97 KiB (-0.21%)

mathieuartu added 2 commits September 11, 2024 14:46

feat(NOTIFY-866): add account syncing

ad8f708

fix: yarn.lock & keyring-controller patch

648fd2b

mathieuartu added the team-notifications Notifications team label Sep 11, 2024

mathieuartu added 4 commits September 11, 2024 15:18

fix: lavamoat policies

1514410

Merge branch 'develop' into feat/add_account_syncing

cd3dc3b

fix: add back isUnlock

36a8adf

feat: add unit tests

757147e

Update LavaMoat policies

28d3ada

mathieuartu added 7 commits September 12, 2024 12:04

fix: mock hook

36836e4

fix: add temporary preview package

fb18699

fix: yarn.lock

358420e

Merge branch 'develop' into feat/add_account_syncing

afd2e74

fix: update preview package

659ffdf

fix: await in e2e tests

62f8aca

Merge branch 'develop' into feat/add_account_syncing

3f71dd9

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 12, 2024

fix: update useAccountSyncingEffect deps

6fec4c5

Merge branch 'develop' into feat/add_account_syncing

0a69a97

mathieuartu added 2 commits September 12, 2024 18:46

test: add coverage

f4c6f8d

Merge branch 'develop' into feat/add_account_syncing

09185ce

fix: update JSDoc and mimic existing hook logic

81b7c05

mathieuartu added 10 commits September 17, 2024 08:56

Merge branch 'develop' into feat/add_account_syncing

0699fda

fix: update package.json & yarn.lock

3869b2d

Merge branch 'develop' into feat/add_account_syncing

8933455

fix: revert package version

55aa550

fix: update package.json & yarn.lock

32b8f99

fix: snaps-sdk related tests

9db8c7a

Merge branch 'develop' into feat/add_account_syncing

80e8c06

Merge branch 'develop' into feat/add_account_syncing

8970eba

feat: add analytics

2b8d616

fix: yarn.lock

ff4daef

mathieuartu added 3 commits September 19, 2024 12:06

Merge branch 'develop' into feat/add_account_syncing

afec489

fix: revert snaps changes

a3b547c

fix: yarn.lock

bbdb18d

Prithpal-Sooriya reviewed Sep 19, 2024

View reviewed changes

.yarn/patches/@metamask-keyring-controller-npm-17.1.1-098cb41930.patch Outdated Show resolved Hide resolved

mathieuartu marked this pull request as ready for review September 19, 2024 11:23

mathieuartu requested review from a team as code owners September 19, 2024 11:23

Prithpal-Sooriya approved these changes Sep 19, 2024

View reviewed changes

matteoscurati approved these changes Sep 19, 2024

View reviewed changes

Merge branch 'develop' into feat/add_account_syncing

0e01f8d

mathieuartu merged commit b15e7cd into develop Sep 19, 2024
75 of 77 checks passed

mathieuartu deleted the feat/add_account_syncing branch September 19, 2024 13:14

github-actions bot locked and limited conversation to collaborators Sep 19, 2024

metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(NOTIFY-866): add account syncing #27060

feat(NOTIFY-866): add account syncing #27060

mathieuartu commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024

socket-security bot commented Sep 11, 2024 •

edited

Loading

mathieuartu commented Sep 11, 2024

metamaskbot commented Sep 11, 2024

metamaskbot commented Sep 12, 2024

codecov bot commented Sep 12, 2024 •

edited

Loading

metamaskbot commented Sep 12, 2024

metamaskbot commented Sep 12, 2024

metamaskbot commented Sep 12, 2024

socket-security bot commented Sep 18, 2024 •

edited

Loading

sonarcloud bot commented Sep 18, 2024

metamaskbot commented Sep 19, 2024

matteoscurati left a comment

sonarcloud bot commented Sep 19, 2024

metamaskbot commented Sep 19, 2024

feat(NOTIFY-866): add account syncing #27060

feat(NOTIFY-866): add account syncing #27060

Conversation

mathieuartu commented Sep 11, 2024 • edited Loading

Description

Related issues

Manual testing steps

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 11, 2024

socket-security bot commented Sep 11, 2024 • edited Loading

Next steps

mathieuartu commented Sep 11, 2024

metamaskbot commented Sep 11, 2024

metamaskbot commented Sep 12, 2024

codecov bot commented Sep 12, 2024 • edited Loading

Codecov Report

metamaskbot commented Sep 12, 2024

metamaskbot commented Sep 12, 2024

metamaskbot commented Sep 12, 2024

socket-security bot commented Sep 18, 2024 • edited Loading

sonarcloud bot commented Sep 18, 2024

Quality Gate passed

metamaskbot commented Sep 19, 2024

matteoscurati left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Sep 19, 2024

Quality Gate passed

metamaskbot commented Sep 19, 2024

mathieuartu commented Sep 11, 2024 •

edited

Loading

socket-security bot commented Sep 11, 2024 •

edited

Loading

codecov bot commented Sep 12, 2024 •

edited

Loading

socket-security bot commented Sep 18, 2024 •

edited

Loading