-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NOTIFY-866): add account syncing #27060
Merged
Merged
Commits on Sep 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ad8f708 - Browse repository at this point
Copy the full SHA ad8f708View commit details -
Configuration menu - View commit details
-
Copy full SHA for 648fd2b - Browse repository at this point
Copy the full SHA 648fd2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1514410 - Browse repository at this point
Copy the full SHA 1514410View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd3dc3b - Browse repository at this point
Copy the full SHA cd3dc3bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36a8adf - Browse repository at this point
Copy the full SHA 36a8adfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 757147e - Browse repository at this point
Copy the full SHA 757147eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 28d3ada - Browse repository at this point
Copy the full SHA 28d3adaView commit details
Commits on Sep 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 36836e4 - Browse repository at this point
Copy the full SHA 36836e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb18699 - Browse repository at this point
Copy the full SHA fb18699View commit details -
Configuration menu - View commit details
-
Copy full SHA for 358420e - Browse repository at this point
Copy the full SHA 358420eView commit details -
Configuration menu - View commit details
-
Copy full SHA for afd2e74 - Browse repository at this point
Copy the full SHA afd2e74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 659ffdf - Browse repository at this point
Copy the full SHA 659ffdfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62f8aca - Browse repository at this point
Copy the full SHA 62f8acaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f71dd9 - Browse repository at this point
Copy the full SHA 3f71dd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fec4c5 - Browse repository at this point
Copy the full SHA 6fec4c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a69a97 - Browse repository at this point
Copy the full SHA 0a69a97View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4c6f8d - Browse repository at this point
Copy the full SHA f4c6f8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 09185ce - Browse repository at this point
Copy the full SHA 09185ceView commit details
Commits on Sep 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 81b7c05 - Browse repository at this point
Copy the full SHA 81b7c05View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f61582 - Browse repository at this point
Copy the full SHA 6f61582View commit details -
Configuration menu - View commit details
-
Copy full SHA for b160e92 - Browse repository at this point
Copy the full SHA b160e92View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8f293a - Browse repository at this point
Copy the full SHA a8f293aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a6a2989 - Browse repository at this point
Copy the full SHA a6a2989View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1f29db - Browse repository at this point
Copy the full SHA d1f29dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for e62156f - Browse repository at this point
Copy the full SHA e62156fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f081813 - Browse repository at this point
Copy the full SHA f081813View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7e9c2c - Browse repository at this point
Copy the full SHA a7e9c2cView commit details
Commits on Sep 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f464606 - Browse repository at this point
Copy the full SHA f464606View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0a42e1 - Browse repository at this point
Copy the full SHA f0a42e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d20e56d - Browse repository at this point
Copy the full SHA d20e56dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b500db7 - Browse repository at this point
Copy the full SHA b500db7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6de9bf - Browse repository at this point
Copy the full SHA d6de9bfView commit details -
chore: Update
asset-list
to Typescript, remove PropTypes (#26952)## **Description** I'm working on Token sorting, and since I was in the area, I took the opportunity to update the components I was touching to Typescript. This PR handles those changes, and I'll work on the actual sorting logic in a separate branch that I will merge with this one. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26952?quickstart=1) ## **Related issues** First step of: https://consensyssoftware.atlassian.net/browse/MMASSETS-356 ## **Manual testing steps** Nothing should be different visually or functionally. ~~I left a comment on a suspicious snapshot test where I can't explain the diff, other than the original snapshot not being accurate based on the mocks~~ 👈 no longer relevant. ## **Screenshots/Recordings** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Brian Bergeron <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e4b987d - Browse repository at this point
Copy the full SHA e4b987dView commit details -
fix: change asset picker button to buttonbase to fix text theming (#2…
…7127) ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> The asset picker in dark mode previously showed the down icon and token symbol in their light mode variants, instead of dark mode. This is because `Button` defaults to the primary variant which hard codes the theme as light mode for all descendant elements. This PR changes the AssetPicker main component from Button to ButtonBase since it does not default to light mode [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27127?quickstart=1) ## **Related issues** Fixes: #27046 ## **Manual testing steps** 1. Change to dark mode 2. Open Send Page 3. Asset symbol and down carat should both render as white 4. Switch to light mode 5. Asset symbol and down carat should both render as black ## **Screenshots/Recordings** ### **Before** <img width="1624" alt="image" src="https://github.com/user-attachments/assets/69e086b1-daec-46d9-b299-74434d58a616"> ### **After** <img width="1624" alt="image" src="https://github.com/user-attachments/assets/709898ae-9766-4902-a089-9183bac8fcc1"> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Configuration menu - View commit details
-
Copy full SHA for bebf1d9 - Browse repository at this point
Copy the full SHA bebf1d9View commit details
Commits on Sep 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0699fda - Browse repository at this point
Copy the full SHA 0699fdaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3869b2d - Browse repository at this point
Copy the full SHA 3869b2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8933455 - Browse repository at this point
Copy the full SHA 8933455View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55aa550 - Browse repository at this point
Copy the full SHA 55aa550View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32b8f99 - Browse repository at this point
Copy the full SHA 32b8f99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9db8c7a - Browse repository at this point
Copy the full SHA 9db8c7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 80e8c06 - Browse repository at this point
Copy the full SHA 80e8c06View commit details
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8970eba - Browse repository at this point
Copy the full SHA 8970ebaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b8d616 - Browse repository at this point
Copy the full SHA 2b8d616View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff4daef - Browse repository at this point
Copy the full SHA ff4daefView commit details
Commits on Sep 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for afec489 - Browse repository at this point
Copy the full SHA afec489View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3b547c - Browse repository at this point
Copy the full SHA a3b547cView commit details -
Configuration menu - View commit details
-
Copy full SHA for bbdb18d - Browse repository at this point
Copy the full SHA bbdb18dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e01f8d - Browse repository at this point
Copy the full SHA 0e01f8dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.