Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NOTIFY-866): add account syncing #27060

Merged
merged 48 commits into from
Sep 19, 2024
Merged

Commits on Sep 11, 2024

  1. Configuration menu
    Copy the full SHA
    ad8f708 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    648fd2b View commit details
    Browse the repository at this point in the history
  3. fix: lavamoat policies

    mathieuartu committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1514410 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cd3dc3b View commit details
    Browse the repository at this point in the history
  5. fix: add back isUnlock

    mathieuartu committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    36a8adf View commit details
    Browse the repository at this point in the history
  6. feat: add unit tests

    mathieuartu committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    757147e View commit details
    Browse the repository at this point in the history
  7. Update LavaMoat policies

    metamaskbot committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    28d3ada View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. fix: mock hook

    mathieuartu committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    36836e4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fb18699 View commit details
    Browse the repository at this point in the history
  3. fix: yarn.lock

    mathieuartu committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    358420e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    afd2e74 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    659ffdf View commit details
    Browse the repository at this point in the history
  6. fix: await in e2e tests

    mathieuartu committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    62f8aca View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3f71dd9 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6fec4c5 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    0a69a97 View commit details
    Browse the repository at this point in the history
  10. test: add coverage

    mathieuartu committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f4c6f8d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    09185ce View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Configuration menu
    Copy the full SHA
    81b7c05 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6f61582 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b160e92 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a8f293a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a6a2989 View commit details
    Browse the repository at this point in the history
  6. fix: conflict

    mathieuartu committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d1f29db View commit details
    Browse the repository at this point in the history
  7. fix: conflicts

    mathieuartu committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e62156f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f081813 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a7e9c2c View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Configuration menu
    Copy the full SHA
    f464606 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f0a42e1 View commit details
    Browse the repository at this point in the history
  3. fix: yarn.lock

    mathieuartu committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    d20e56d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b500db7 View commit details
    Browse the repository at this point in the history
  5. Update LavaMoat policies

    metamaskbot committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    d6de9bf View commit details
    Browse the repository at this point in the history
  6. chore: Update asset-list to Typescript, remove PropTypes (#26952)

    ## **Description**
    
    I'm working on Token sorting, and since I was in the area, I took the
    opportunity to update the components I was touching to Typescript. This
    PR handles those changes, and I'll work on the actual sorting logic in a
    separate branch that I will merge with this one.
    
    [![Open in GitHub
    Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26952?quickstart=1)
    
    ## **Related issues**
    
    First step of:
    https://consensyssoftware.atlassian.net/browse/MMASSETS-356
    
    ## **Manual testing steps**
    
    Nothing should be different visually or functionally. ~~I left a comment
    on a suspicious snapshot test where I can't explain the diff, other than
    the original snapshot not being accurate based on the mocks~~ 👈 no
    longer relevant.
    
    ## **Screenshots/Recordings**
    
    ## **Pre-merge author checklist**
    
    - [x] I've followed [MetaMask Contributor
    Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
    Extension Coding
    Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
    - [x] I've completed the PR template to the best of my ability
    - [x] I’ve included tests if applicable
    - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [x] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    ## **Pre-merge reviewer checklist**
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    
    ---------
    
    Co-authored-by: Brian Bergeron <[email protected]>
    2 people authored and mathieuartu committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    e4b987d View commit details
    Browse the repository at this point in the history
  7. fix: change asset picker button to buttonbase to fix text theming (#2…

    …7127)
    
    ## **Description**
    
    <!--
    Write a short description of the changes included in this pull request,
    also include relevant motivation and context. Have in mind the following
    questions:
    1. What is the reason for the change?
    2. What is the improvement/solution?
    -->
    The asset picker in dark mode previously showed the down icon and token
    symbol in their light mode variants, instead of dark mode. This is
    because `Button` defaults to the primary variant which hard codes the
    theme as light mode for all descendant elements. This PR changes the
    AssetPicker main component from Button to ButtonBase since it does not
    default to light mode
    
    [![Open in GitHub
    Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27127?quickstart=1)
    
    ## **Related issues**
    
    Fixes: #27046 
    
    ## **Manual testing steps**
    
    1. Change to dark mode
    2. Open Send Page
    3. Asset symbol and down carat should both render as white
    4. Switch to light mode
    5. Asset symbol and down carat should both render as black
    
    ## **Screenshots/Recordings**
    
    ### **Before**
    
    <img width="1624" alt="image"
    src="https://github.com/user-attachments/assets/69e086b1-daec-46d9-b299-74434d58a616">
    
    
    ### **After**
    
    <img width="1624" alt="image"
    src="https://github.com/user-attachments/assets/709898ae-9766-4902-a089-9183bac8fcc1">
    
    
    ## **Pre-merge author checklist**
    
    - [x] I've followed [MetaMask Contributor
    Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
    Extension Coding
    Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
    - [x] I've completed the PR template to the best of my ability
    - [x] I’ve included tests if applicable
    - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [x] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    ## **Pre-merge reviewer checklist**
    
    - [x] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [x] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    jclancy93 authored and mathieuartu committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    bebf1d9 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Configuration menu
    Copy the full SHA
    0699fda View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3869b2d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8933455 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    55aa550 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    32b8f99 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9db8c7a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    80e8c06 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Configuration menu
    Copy the full SHA
    8970eba View commit details
    Browse the repository at this point in the history
  2. feat: add analytics

    mathieuartu committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    2b8d616 View commit details
    Browse the repository at this point in the history
  3. fix: yarn.lock

    mathieuartu committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ff4daef View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Configuration menu
    Copy the full SHA
    afec489 View commit details
    Browse the repository at this point in the history
  2. fix: revert snaps changes

    mathieuartu committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a3b547c View commit details
    Browse the repository at this point in the history
  3. fix: yarn.lock

    mathieuartu committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    bbdb18d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0e01f8d View commit details
    Browse the repository at this point in the history