test: add back skipped solana tests

[Prithpal-Sooriya]

Description

adding driver delay as these tests rely on snap balances which are async

Changelog

CHANGELOG entry: null

Related issues

Fixes: #37824, https://consensyssoftware.atlassian.net/browse/ASSETS-1809

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Re-enables previously skipped Solana E2E tests and adds short driver delays to stabilize async balance and activity assertions.

• Tests (Solana E2E):
  • Re-enabled suites:
    • test/e2e/tests/send/send-solana.spec.ts
    • test/e2e/tests/solana/send-flow.spec.ts
    • test/e2e/tests/solana/transaction-activity-list.spec.ts
    • Unskips non-zero balance cases in test/e2e/tests/solana/check-balance.spec.ts.
  • Stability improvements:
    • Insert await driver.delay(5000) before balance checks, activity assertions, and send flows to wait for snap-driven async data (e.g., in check-balance.spec.ts, send-solana.spec.ts, send-flow.spec.ts, transaction-activity-list.spec.ts).
  • Minor test flow tweaks:
    • Ensure asset page is ready by waiting for 50 SOL before proceeding in send-solana.spec.ts.

^{Written by Cursor Bugbot for commit 4cf490a. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [4cf490a]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1228 ± 102 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1228	1006	1559	102	1282	1409
			load	1026	851	1323	91	1075	1216
			domContentLoaded	1020	846	1318	90	1068	1207
			domInteractive	26	15	162	22	22	81
			firstPaint	520	90	1305	399	997	1161
			backgroundConnect	213	196	245	11	218	241
			firstReactRender	29	19	151	15	30	50
			getState	33	15	108	17	37	75
			initialActions	1	0	6	1	1	2
			loadScripts	814	655	1120	88	857	1004
			setupStore	11	7	40	5	12	20
			numNetworkReqs	12	5	77	20	5	72
	Browserify	Power User Home	uiStartup	2029	1664	2678	227	2102	2538
			load	1005	883	1455	128	999	1333
			domContentLoaded	990	873	1447	127	977	1314
			domInteractive	34	16	148	30	30	127
			firstPaint	555	91	1400	399	944	1286
			backgroundConnect	266	203	684	114	233	544
			firstReactRender	61	38	119	19	62	109
			getState	187	127	682	74	192	229
			initialActions	1	0	4	1	1	2
			loadScripts	783	674	1238	127	772	1112
			setupStore	19	8	78	9	24	33
			numNetworkReqs	103	64	283	55	97	273
	Webpack	Standard Home	uiStartup	775	667	1020	70	801	944
			load	605	543	843	69	625	778
			domContentLoaded	600	538	835	68	622	772
			domInteractive	25	14	109	22	21	89
			firstPaint	243	65	845	178	216	632
			backgroundConnect	9	5	23	4	11	17
			firstReactRender	26	19	43	6	30	36
			getState	23	12	54	9	29	41
			initialActions	1	0	5	1	1	1
			loadScripts	598	536	826	67	621	765
			setupStore	10	5	44	5	12	17
			numNetworkReqs	12	5	78	20	5	74
	Webpack	Power User Home	uiStartup	1697	1336	2943	307	2019	2236
			load	692	600	1315	107	692	948
			domContentLoaded	681	594	1309	108	680	944
			domInteractive	38	19	198	32	35	126
			firstPaint	275	103	971	192	261	714
			backgroundConnect	69	7	659	156	20	589
			firstReactRender	63	48	90	9	68	81
			getState	200	131	781	108	190	249
			initialActions	1	0	5	1	1	2
			loadScripts	678	592	1297	105	677	935
			setupStore	22	10	57	11	24	49
			numNetworkReqs	171	64	422	87	219	397
Firefox	Browserify	Standard Home	uiStartup	1287	1063	1704	138	1367	1594
			load	1056	914	1278	85	1108	1214
			domContentLoaded	1055	913	1278	85	1108	1214
			domInteractive	53	30	135	25	76	104
			firstPaint	-	-	-	-	-	-
			backgroundConnect	44	21	199	30	45	108
			firstReactRender	23	18	49	5	23	35
			getState	12	6	197	19	10	23
			initialActions	1	0	2	0	2	2
			loadScripts	1028	893	1259	75	1080	1163
			setupStore	13	5	90	12	13	35
			numNetworkReqs	11	5	65	15	6	59
	Browserify	Power User Home	uiStartup	2626	2059	4309	466	2671	4081
			load	1212	1037	2646	230	1248	1498
			domContentLoaded	1212	1037	2645	230	1248	1498
			domInteractive	113	33	562	87	108	339
			firstPaint	-	-	-	-	-	-
			backgroundConnect	114	41	587	88	120	279
			firstReactRender	61	37	119	18	65	99
			getState	275	25	961	210	378	758
			initialActions	2	1	7	1	2	3
			loadScripts	1172	961	2626	204	1201	1456
			setupStore	180	9	767	205	231	691
			numNetworkReqs	99	63	301	51	103	229
	Webpack	Standard Home	uiStartup	1513	1285	1894	150	1643	1785
			load	1241	1073	1566	107	1313	1445
			domContentLoaded	1241	1073	1565	107	1313	1445
			domInteractive	57	28	143	33	80	128
			firstPaint	-	-	-	-	-	-
			backgroundConnect	47	18	170	29	49	114
			firstReactRender	26	19	66	6	28	34
			getState	12	6	88	10	13	26
			initialActions	2	0	4	1	3	4
			loadScripts	1214	1055	1447	102	1286	1383
			setupStore	14	6	89	14	13	40
			numNetworkReqs	12	5	66	17	7	64
	Webpack	Power User Home	uiStartup	2931	2206	5202	608	3001	4321
			load	1510	1228	2834	380	1531	2589
			domContentLoaded	1509	1228	2833	380	1531	2589
			domInteractive	125	33	965	141	106	474
			firstPaint	-	-	-	-	-	-
			backgroundConnect	147	29	1068	170	153	407
			firstReactRender	67	42	242	30	67	136
			getState	245	82	961	202	344	788
			initialActions	4	1	60	9	3	8
			loadScripts	1451	1203	2686	318	1489	2440
			setupStore	203	9	1022	224	288	705
			numNetworkReqs	102	59	252	61	79	240

📊 Page Load Benchmark Results

Current Commit: 4cf490a | Date: 12/1/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.04s (±39ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
• domContentLoaded-> current mean value: 722ms (±36ms) 🟢 | historical mean value: 727ms ⬇️ (historical data)
• firstContentfulPaint-> current mean value: 77ms (±12ms) 🟢 | historical mean value: 80ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	39ms	1.01s	1.31s	1.07s	1.31s
domContentLoaded	722ms	36ms	701ms	975ms	751ms	975ms
firstPaint	77ms	12ms	60ms	180ms	92ms	180ms
firstContentfulPaint	77ms	12ms	60ms	180ms	92ms	180ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 58 Bytes (0%)
• ui: 13 Bytes (0%)
• common: 20 Bytes (0%)

[Prithpal-Sooriya]

I would like QA thoughts on this.
These tests do pass, but balances are async and require a little bit of time to load (even if the API requests are mocked)

[Prithpal-Sooriya]

NOTE, that these tests for solana are with the BIP-44 state flag set to 0 - BIP-44 is not enabled).

If BIP-44 is enabled, it would require a much larger UI change for these e2e tests to pass. Example changes:

1. solana is added directly into each account, so there is no need to add a solana account.
2. the home screen will show an aggregated balance across EVM and non-EVM.

[cursor]

Bug: Missing delay in similar non-zero balance test

The test "full flow of USD with a positive balance account" is missing the driver.delay(5000) that was added to "full flow of SOL with a positive balance account" at line 201. Both tests have identical configurations (showNativeTokenAsMainBalance: true, mockGetTransactionSuccess: true) and expect a non-zero balance of '50'. If async balance loading requires a delay for the SOL test before checkPageIsLoaded('50'), the USD test with the same setup likely needs it too, otherwise it may be flaky.

test/e2e/tests/solana/send-flow.spec.ts#L64-L75

metamask-extension/test/e2e/tests/solana/send-flow.spec.ts

Lines 64 to 75 in 4cf490a

	it('full flow of USD with a positive balance account', async function () {
	this.timeout(120000);
	await withSolanaAccountSnap(
	{
	title: this.test?.fullTitle(),
	showNativeTokenAsMainBalance: true,
	mockGetTransactionSuccess: true,
	},
	async (driver) => {
	const homePage = new NonEvmHomepage(driver);
	await homePage.checkPageIsLoaded('50');

test/e2e/tests/solana/send-flow.spec.ts#L200-L203

metamask-extension/test/e2e/tests/solana/send-flow.spec.ts

Lines 200 to 203 in 4cf490a

	async (driver) => {
	await driver.delay(5000);
	const homePage = new NonEvmHomepage(driver);
	await homePage.checkPageIsLoaded('50');

 

---

Bug: Missing delay before identical balance check method call

The "and transaction fails" test in send-flow.spec.ts calls checkGetBalance('50', 'SOL') without a delay before it, while the nearly identical "For a non 0 balance account - SOL balance" test in check-balance.spec.ts has driver.delay(5000) added before the same call. Both tests have showNativeTokenAsMainBalance: true and default non-zero balance configuration. If async balance loading requires a delay before this assertion in one file, it likely requires it in the other as well.

test/e2e/tests/solana/send-flow.spec.ts#L317-L320

metamask-extension/test/e2e/tests/solana/send-flow.spec.ts

Lines 317 to 320 in 4cf490a

	},
	async (driver) => {
	const homePage = new NonEvmHomepage(driver);
	await homePage.checkGetBalance('50', 'SOL');

test/e2e/tests/solana/check-balance.spec.ts#L108-L110

metamask-extension/test/e2e/tests/solana/check-balance.spec.ts

Lines 108 to 110 in 4cf490a

	const homePage = new NonEvmHomepage(driver);
	await driver.delay(5000);
	await homePage.checkGetBalance('50', 'SOL');

 

---