Skip to content

test: add back skipped solana tests #38449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Prithpal-Sooriya wants to merge 1 commit into from
+13 −15
Closed

test: add back skipped solana tests #38449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/e2e/tests/send/send-solana.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ import { DEFAULT_SOLANA_TEST_DAPP_FIXTURE_OPTIONS } from '../../flask/solana-wal
import { withSolanaAccountSnap } from '../solana/common-solana';
import { mockSendRedesignFeatureFlag } from './common';

// BUG #37824 With BIP44 turned on balance on Solana is always zero even when it is mocked
// eslint-disable-next-line mocha/no-skipped-tests
describe.skip('Send Solana', function () {
describe('Send Solana', function () {
it('it should be possible to send SOL', async function () {
await withSolanaAccountSnap(
{
Expand All @@ -23,6 +21,8 @@ describe.skip('Send Solana', function () {
driver,
);

await driver.delay(5000);
Copy link
Contributor Author

@Prithpal-Sooriya Prithpal-Sooriya Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like QA thoughts on this.
These tests do pass, but balances are async and require a little bit of time to load (even if the API requests are mocked)

Copy link
Contributor Author

@Prithpal-Sooriya Prithpal-Sooriya Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE, that these tests for solana are with the BIP-44 state flag set to 0 - BIP-44 is not enabled).

If BIP-44 is enabled, it would require a much larger UI change for these e2e tests to pass. Example changes:

  1. solana is added directly into each account, so there is no need to add a solana account.
  2. the home screen will show an aggregated balance across EVM and non-EVM.


await nonEvmHomepage.clickOnSendButton();

// Navigating immediate will not work - we wait in the asset page to catch up
Expand Down
10 changes: 4 additions & 6 deletions test/e2e/tests/solana/check-balance.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,7 @@ describe('Check balance', function (this: Suite) {
},
);
});
// BUG #37824 With BIP44 turned on mocking Solana network responses no longer works
// eslint-disable-next-line mocha/no-skipped-tests
it.skip('For a non 0 balance account - USD balance', async function () {
it('For a non 0 balance account - USD balance', async function () {
await withSolanaAccountSnap(
{
title: this.test?.fullTitle(),
Expand All @@ -95,20 +93,20 @@ describe('Check balance', function (this: Suite) {
},
async (driver) => {
const homePage = new NonEvmHomepage(driver);
await driver.delay(5000);
await homePage.checkGetBalance('$5,643.50', 'USD');
},
);
});
// BUG #37824 With BIP44 turned on mocking Solana network responses no longer works
// eslint-disable-next-line mocha/no-skipped-tests
it.skip('For a non 0 balance account - SOL balance', async function () {
it('For a non 0 balance account - SOL balance', async function () {
await withSolanaAccountSnap(
{
title: this.test?.fullTitle(),
showNativeTokenAsMainBalance: true,
},
async (driver) => {
const homePage = new NonEvmHomepage(driver);
await driver.delay(5000);
await homePage.checkGetBalance('50', 'SOL');
},
);
Expand Down
5 changes: 2 additions & 3 deletions test/e2e/tests/solana/send-flow.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,7 @@ import { withSolanaAccountSnap } from './common-solana';

const commonSolanaAddress = 'GYP1hGem9HBkYKEWNUQUxEwfmu4hhjuujRgGnj5LrHna';

// BUG #37824 - With BIP44 turned on mocking Solana network responses no longer works
// eslint-disable-next-line mocha/no-skipped-tests
describe.skip('Send flow', function (this: Suite) {
describe('Send flow', function (this: Suite) {
it('with some field validation', async function () {
this.timeout(120000);
await withSolanaAccountSnap(
Expand Down Expand Up @@ -200,6 +198,7 @@ describe.skip('Send flow', function (this: Suite) {
mockGetTransactionSuccess: true,
},
async (driver) => {
await driver.delay(5000);
const homePage = new NonEvmHomepage(driver);
await homePage.checkPageIsLoaded('50');
assert.equal(
Expand Down
7 changes: 4 additions & 3 deletions test/e2e/tests/solana/transaction-activity-list.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,7 @@ import {
withSolanaAccountSnap,
} from './common-solana';

// BUG #37824 - With BIP44 turned on mocking Solana network responses no longer works
// eslint-disable-next-line mocha/no-skipped-tests
describe.skip('Transaction activity list', function (this: Suite) {
describe('Transaction activity list', function (this: Suite) {
it('user can see activity list and a confirmed transaction details', async function () {
this.timeout(120000);
await withSolanaAccountSnap(
Expand All @@ -24,6 +22,7 @@ describe.skip('Transaction activity list', function (this: Suite) {
const homePage = new NonEvmHomepage(driver);
await homePage.goToActivityList();

await driver.delay(5000);
const activityList = new ActivityListPage(driver);
await activityList.checkTxAction({ action: 'Sent' });
await activityList.checkTxAmountInActivity('-0.00708 SOL', 1);
Expand Down Expand Up @@ -61,6 +60,8 @@ describe.skip('Transaction activity list', function (this: Suite) {
const homePage = new NonEvmHomepage(driver);
await homePage.checkPageIsLoaded('50');
await homePage.goToActivityList();

await driver.delay(5000);
const activityList = new ActivityListPage(driver);
await activityList.checkFailedTxNumberDisplayedInActivity(1);
await activityList.checkTxAction({ action: 'Interaction' });
Expand Down
Loading