chore(WPN-1652): align Solana AssetsService read API with snap-networks-utils - #635
Closed
ulissesferreira wants to merge 1 commit into
Closed
chore(WPN-1652): align Solana AssetsService read API with snap-networks-utils#635ulissesferreira wants to merge 1 commit into
ulissesferreira wants to merge 1 commit into
Conversation
This was referenced Jul 31, 2026
ulissesferreira
marked this pull request as ready for review
August 2, 2026 17:38
ulissesferreira
force-pushed
the
WPN-1652-align-assets-service-api
branch
from
August 2, 2026 23:36
fbc8b66 to
d56be38
Compare
…ks-utils Co-authored-by: Cursor <cursoragent@cursor.com>
ulissesferreira
force-pushed
the
WPN-1652-align-assets-service-api
branch
from
August 5, 2026 10:33
d56be38 to
48ddcf8
Compare
|
4 tasks
4 tasks
cursor Bot
pushed a commit
to MetaMask/internal-snaps
that referenced
this pull request
Aug 5, 2026
…ks-utils Add getAccountAssetByID, getAccountAssetsByIDs, getAccountAssetsByScope, and getAccountAssetsForAllActiveScopes. Update Keyring, Send, send render, and refreshSend to use the new API. No behavior change — still reads from Snap-owned assetEntities via AssetsRepository. Migrated from MetaMask/snap-solana-wallet#635. Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getAccountAssetByID,getAccountAssetsByIDs,getAccountAssetsByScoperefreshSendcron to use the new APIassetEntitiesviaAssetsRepositoryTest plan
yarn workspace @metamask/solana-wallet-snap test src/core/services/assets/AssetsService.test.tsyarn workspace @metamask/solana-wallet-snap test src/core/services/send/SendService.test.tsPart of the WPN-1652 staged migration split (PR 1 of 8).