Skip to content
This repository was archived by the owner on Aug 7, 2026. It is now read-only.

feat(WPN-1476): disable Snap tracking with CoreAssetsAdapter hardcoded (Lane B - PR 5b) - #639

Closed
ulissesferreira wants to merge 1 commit into
WPN-1476-migrate-solana-assets-controller-no-flagfrom
WPN-1476-hardcode-core-assets-adapter
Closed

feat(WPN-1476): disable Snap tracking with CoreAssetsAdapter hardcoded (Lane B - PR 5b)#639
ulissesferreira wants to merge 1 commit into
WPN-1476-migrate-solana-assets-controller-no-flagfrom
WPN-1476-hardcode-core-assets-adapter

Conversation

@ulissesferreira

@ulissesferreira ulissesferreira commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Disable Snap balance tracking in KeyringAccountMonitor (transactions only)
  • AccountsSynchronizer syncs transactions via getAccountAssetsForAllActiveScopes (Core reads), no fetch/saveMany
  • Fungible reads remain unconditionally routed through Core (no migration stage conditionals)

Test plan

  • yarn workspace @metamask/solana-wallet-snap test:core
  • KeyringAccountMonitor tests updated for transaction-only persistence

@ulissesferreira
ulissesferreira force-pushed the WPN-1476-hardcode-core-assets-adapter branch 2 times, most recently from a3d9b9f to f87679d Compare July 31, 2026 16:27
@ulissesferreira
ulissesferreira force-pushed the WPN-1476-hardcode-core-assets-adapter branch from f87679d to b39f84d Compare July 31, 2026 23:01
@ulissesferreira ulissesferreira mentioned this pull request Aug 2, 2026
Closed
6 tasks
@ulissesferreira
ulissesferreira force-pushed the WPN-1476-hardcode-core-assets-adapter branch 2 times, most recently from 3569f70 to ced85b8 Compare August 2, 2026 23:49
@ulissesferreira
ulissesferreira force-pushed the WPN-1476-hardcode-core-assets-adapter branch from ced85b8 to 7aeabb2 Compare August 3, 2026 00:13
@ulissesferreira
ulissesferreira force-pushed the WPN-1476-hardcode-core-assets-adapter branch from 7aeabb2 to 51b037d Compare August 5, 2026 10:33
@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ulissesferreira