Add H2 into our fuel media #517
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This PR shows how to add H2 to our current fuel media.
We can either merge it and it will be a breaking change but require a limited amount of work, simply add one equation, saying that H2 fraction is zero, or we can just close it and leave it as a how to add a different species in our fuel.
I am sure that I made the changes correctly because I made a temporary variable to compute LHV directly, instead of using HHV, and I found the same result when varying H2 proportion :
Type of change
package.mo
)Will it break anything in previous models ?
Checklist
You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.