Skip to content

Add H2 into our fuel media #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Add H2 into our fuel media #517

wants to merge 6 commits into from

Conversation

pierre-eliep-met
Copy link
Collaborator

@pierre-eliep-met pierre-eliep-met commented Dec 19, 2024

Goal

This PR shows how to add H2 to our current fuel media.
We can either merge it and it will be a breaking change but require a limited amount of work, simply add one equation, saying that H2 fraction is zero, or we can just close it and leave it as a how to add a different species in our fuel.

I am sure that I made the changes correctly because I made a temporary variable to compute LHV directly, instead of using HHV, and I found the same result when varying H2 proportion :

Units.SpecificEnthalpy LHV = HHV - 2202.92069 *  X_fuel_H*1e4 "J/kg can be assigned in component modifiers";
Units.SpecificEnthalpy LHV_test = (lhv_mass_H2*X_fuel_H2 + lhv_mass_CH4*X_fuel_CH4 + lhv_mass_C2H6*X_fuel_C2H6 + lhv_mass_C3H8*X_fuel_C3H8 + lhv_mass_C4H10*X_fuel_C4H10_n_butane)*1e6;

image

Type of change

  • Bugfix
  • New feature
  • Refactoring change
  • Release & Version Update (don't forget to change the version number in package.mo)

Will it break anything in previous models ?

  • Breaking change (If yes, make sure to point it out in the changelog)
  • Non-Breaking change

Checklist

  • I have added the appropriate tags, reviewers, projects (and detailed the size and priority of my PR) and linked issues to this PR
  • I have performed a self-review of my own code
  • I have checked that all existing tests pass
  • I have checked that my work is compatible with OpenModelica
  • I have added/updated tests that prove my development works and does not break anything.
  • I have made corresponding changes or additions to the documentation (in Notion documentation)
  • I have added corresponding entries to the Changelog
  • I have checked for conflicts with target branch, and merged/rebased in consequence

You can also fill these out after creating the PR, but make sure to check them all before submitting your PR for review.

@pierre-eliep-met pierre-eliep-met marked this pull request as draft April 30, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant