chore: remove PAY_DEMO_ENABLED + pay/demo surface entirely - #113
Merged
Conversation
The demo simulate-KYC endpoint (introduced in #53) was guarded by NETWORK in [local, standalone] OR PAY_DEMO_ENABLED === "true". The entire surface is being purged — handler, tests, route registration, .env.example, README mentions, and the demo directory. No consumer relies on it (verified org-wide).
7 tasks
AquiGorka
added a commit
that referenced
this pull request
Jun 8, 2026
## Summary Deletes the 3 `OTEL_*` lines from `fly.testnet.toml [env]` that duplicated iac-owned secret names. - `iac/destinations.yaml` is the source of truth for `OTEL_DENO`, `OTEL_SERVICE_NAME`, and `OTEL_EXPORTER_OTLP_PROTOCOL` on this testnet Fly app. - The `[env]` entries were silently shadowed by the Fly secrets iac sets; they would have rotted if iac ever rotated the values. - Current `[env]` values match what iac sets, so this is a **no-runtime-change** cleanup — iac/destinations.yaml remains the sole source of truth. ## Changes - `fly.testnet.toml`: drop 3 lines inside `[env]` — `OTEL_DENO`, `OTEL_SERVICE_NAME`, `OTEL_EXPORTER_OTLP_PROTOCOL`. - `deno.json`: 0.7.4 → 0.7.5 (independent final commit; rebased onto post-#113 main). ## Test plan - [x] `deno fmt --check` clean - [x] `deno lint` clean - [x] `deno task test:unit` — 64 passed, 0 failed - [x] `deno task test:integration` — 96 passed, 0 failed - [x] `deno task test:pay` — 116 passed, 0 failed - [x] `python3 tomllib` parses `fly.testnet.toml` cleanly - [x] `git grep -nF` for each deleted line returns 0 hits on the branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the demo surface introduced in #53. The
POST /api/v1/pay/demo/simulate-kycroute, its handler, the env-var gate (PAY_DEMO_ENABLED), the local/standalone-network auto-mount, both demo test files, and all README +.env.examplementions are deleted. No transitional 410 stub — bare-delete.Verified no consumers org-wide (PM grep across all 18 Moonlight-Protocol repos, including local-dev setup scripts, testnet/, recording/, playwright/ — zero hits outside this repo before this PR).
Local verification
deno fmt --check: cleandeno lint: cleandeno task test:unit: 64 passed | 0 faileddeno task test:integration: 99 passed | 0 failed (matches PR feat(executor): pre-flight OpEx fee check before bundle submission #111 baseline exactly)deno task test:pay: 116 passed | 0 failed (= 132 main baseline − 16 deleted demoDeno.testcalls)curl POST /api/v1/pay/demo/simulate-kyconNETWORK=local: HTTP 404curl POST /api/v1/pay/demo/simulate-kyconNETWORK=testnet+PAY_DEMO_ENABLED=true: HTTP 404 (env var no longer wires anything)curl POST /api/v1/pay/kycand/pay/report: HTTP 401 (unchanged contract)Last commit is the version bump
0.7.3 → 0.7.4alone.