Modify galaxy collection reqs to use galaxy instead of git for faster installs#176
Modify galaxy collection reqs to use galaxy instead of git for faster installs#176jwlodek wants to merge 1 commit intoNSLS2:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request aims to improve installation performance by migrating Ansible Galaxy collection dependencies from git sources to Galaxy-hosted versions. The changes modify how collections are installed and which collections are included in the requirements.
Changes:
- Migrated three collections (community.general, ansible.posix, containers.podman) from git sources to Galaxy sources with version pins
- Removed the conditional installation of community.docker collection from the Python deployment script, adding it instead to the requirements.yml file
- Simplified subprocess.run call for ansible-galaxy installation to show output directly to users
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| collections/requirements.yml | Migrated three collections from git to Galaxy sources, commented out awx.awx collection, and added community.docker collection |
| scripts/deploy_local_config.py | Removed capture_output and text parameters from ansible-galaxy subprocess call and removed conditional community.docker installation logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # source: https://github.com/containers/ansible-podman-collections.git | ||
| # type: git | ||
| version: 1.16.2 | ||
| - # name: nsls2.general |
There was a problem hiding this comment.
The nsls2.general collection is used in scripts/deploy_local_ioc_config.yml (line 39: nsls2.general.nsls2network_find), but the name field is commented out on line 16, which means it won't be properly installed. The name field should be uncommented like the other collections that were migrated from git to Galaxy sources. Additionally, since this is a custom collection from GitHub, it should remain as a git source installation (which it already is), but with the name uncommented.
| - # name: nsls2.general | |
| - name: nsls2.general |
| - name: community.docker | ||
| # source: | ||
| version: 3.4.9 |
There was a problem hiding this comment.
The community.docker collection is being added here but there's no evidence of it being used anywhere in the codebase. The container functionality in this project uses the docker command-line tool directly (via scripts/setup_container.sh) and the Ansible docker connection plugin (which is built into ansible-core). Unless there's a specific need for community.docker modules that isn't visible in the current code, this collection dependency appears unnecessary and could be removed to reduce installation time and dependencies.
| - name: community.docker | |
| # source: | |
| version: 3.4.9 |
No description provided.