Skip to content

Modify galaxy collection reqs to use galaxy instead of git for faster installs #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jwlodek wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Modify galaxy collection reqs to use galaxy instead of git for faster installs #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions collections/requirements.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,25 @@
---

collections:
- # name: community.general
source: https://github.com/ansible-collections/community.general.git
type: git
- name: community.general
# source: https://github.com/ansible-collections/community.general.git
# type: git
version: 10.1.0
- # name: ansible.posix
source: https://github.com/ansible-collections/ansible.posix.git
type: git
- name: ansible.posix
# source: https://github.com/ansible-collections/ansible.posix.git
# type: git
version: 1.5.1
- # name: containers.podman
source: https://github.com/containers/ansible-podman-collections.git
type: git
- name: containers.podman
# source: https://github.com/containers/ansible-podman-collections.git
# type: git
version: 1.16.2
- # name: nsls2.general
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nsls2.general collection is used in scripts/deploy_local_ioc_config.yml (line 39: nsls2.general.nsls2network_find), but the name field is commented out on line 16, which means it won't be properly installed. The name field should be uncommented like the other collections that were migrated from git to Galaxy sources. Additionally, since this is a custom collection from GitHub, it should remain as a git source installation (which it already is), but with the name uncommented.

Suggested change
- # name: nsls2.general
- name: nsls2.general

Copilot uses AI. Check for mistakes.
source: https://github.com/nsls2/nsls2.general.git
type: git
- # name: awx.awx
source: https://github.com/nsls2/awx.git
type: git
version: nsls-ii-prod
# - # name: awx.awx
# source: https://github.com/nsls2/awx.git
# type: git
# version: nsls-ii-prod
- name: community.docker
# source:
version: 3.4.9
Comment on lines +23 to +25
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The community.docker collection is being added here but there's no evidence of it being used anywhere in the codebase. The container functionality in this project uses the docker command-line tool directly (via scripts/setup_container.sh) and the Ansible docker connection plugin (which is built into ansible-core). Unless there's a specific need for community.docker modules that isn't visible in the current code, this collection dependency appears unnecessary and could be removed to reduce installation time and dependencies.

Suggested change
- name: community.docker
# source:
version: 3.4.9

Copilot uses AI. Check for mistakes.
5 changes: 1 addition & 4 deletions scripts/deploy_local_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ def install_galaxy_collection(
cmd.extend(["-p", str(collections_path.absolute())])
try:
logger.info(f"Installing required ansible-galaxy collection(s): {name}")
subprocess.run(cmd, capture_output=True, text=True, check=True)
subprocess.run(cmd, check=True)
except subprocess.CalledProcessError as e:
raise RuntimeError(f"Failed to install galaxy collection {name}: {e}") from e

Expand Down Expand Up @@ -369,9 +369,6 @@ def main():
)
install_galaxy_collection(str(top_path), force=True)

if args.container:
install_galaxy_collection("community.docker")

if args.all:
logger.info("Finding all examples for all IOC types")
device_roles_path = top_path / "roles/device_roles"
Expand Down