Conversation
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Greptile SummaryThis PR performs pre-release housekeeping for v0.2: the primary functional change is renaming
Confidence Score: 3/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["update_eigenbasis_and_exp_avgs()\n(renamed from update_eigenbasis_and_momentum)"] --> B
B["Step 1: Project exp_avg → original basis\nprecondition(exp_avg, eigenbasis_list, dims=[[0],[1]])"]
B --> C{use_eigh?}
C -- "True" --> D["get_eigenbasis_eigh(kronecker_factor_list)\n→ updated_eigenbasis_list\n(exp_avg_sq unchanged)"]
C -- "False" --> E["get_eigenbasis_qr(kronecker_factor_list, eigenbasis_list,\nexp_avg_sq, power_iter_steps)\n→ updated_eigenbasis_list, exp_avg_sq"]
D --> F
E --> F
F["Step 3: Project exp_avg → new eigenbasis\nprecondition(exp_avg, updated_eigenbasis_list, dims=[[0],[0]])"]
F --> G["Return (updated_eigenbasis_list, exp_avg, exp_avg_sq)"]
G --> H["Caller (SOAP.step) updates state:\nstate['Q_L'], state['Q_R'] = updated_eigenbasis_list\nstate['exp_avg'] = exp_avg\nstate['exp_avg_sq'] = exp_avg_sq"]
|
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Hao Wu <skyw@nvidia.com>
|
/ok to test 7360c6b |
Test Results 48 files ±0 98 suites ±0 1m 15s ⏱️ +4s Results for commit d499815. ± Comparison against base commit eead338. This pull request removes 18 and adds 18 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Signed-off-by: Hao Wu <skyw@nvidia.com>
|
/ok to test d499815 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Improve some function interfaces.
Add missing files and registry.
Minor update to documents.