refactor: clean up multi-node config and use num_instances#805
Closed
AdamRajfer wants to merge 1 commit intomainfrom
Closed
refactor: clean up multi-node config and use num_instances#805AdamRajfer wants to merge 1 commit intomainfrom
AdamRajfer wants to merge 1 commit intomainfrom
Conversation
Replace boolean multi-instance flag with num_instances count. Set up node IP discovery and per-instance routing for future multi-node runs. Update examples, docs, and tests. Signed-off-by: Adam Rajfer <arajfer@nvidia.com>
github-actions
bot
added
documentation
Contributor
Author
|
/ok to test bf5f330 |
Contributor
|
Closing as we've merged a more extended version in #757 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace boolean multi-instance flag with
num_instancescount in slurm execution config. Set up node IP discovery and per-instance routing for multi-node deployments. Clean up multi-node examples and docs. UseOmegaConf.selectfor safenum_instancesaccess across all executor types. Update tests.