fix(auth): skip renewal for non-expiring sandbox JWTs - #3686
Merged
Merged
Conversation
pimlock
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 25, 2026 00:24
|
🌿 Preview your docs: https://nvidia-preview-pr-3686.docs.buildwithfern.com/openshell |
|
Label |
8 tasks
pimlock
force-pushed
the
skip-nonexpiring-session-refresh/pm
branch
from
September 25, 2026 03:03
ea90ab9 to
aff292f
Compare
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
drew
force-pushed
the
skip-nonexpiring-session-refresh/pm
branch
from
September 25, 2026 03:21
aff292f to
e625ae1
Compare
drew
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop the sandbox supervisor from renewing non-expiring local session JWTs roughly once per second. These tokens use
exp = 0, which the refresh scheduler treated as already expired even though the gateway treats it as non-expiring.Currently, tokens with
exp = 0cause a refresh every second, because the "is token expired" condition is met at all times.Related Issue
No issue required: this is an obvious localized regression in the sandbox JWT refresh scheduler.
Changes
exp = 0.Testing
mise run pre-commitpassesmise run testpasses, including the updated renewal testOPENSHELL_E2E_DOCKER_TEST=sandbox_lifecycle mise run e2e:rustpasses: CLI conformance and 15 sandbox lifecycle testsChecklist