Add .codecov.yml status checks #618
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter St. John <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
=======================================
Coverage 86.62% 86.62%
=======================================
Files 116 116
Lines 6961 6961
=======================================
Hits 6030 6030
Misses 931 931 ☔ View full report in Codecov by Sentry. |
trvachov
reviewed
Jan 21, 2025
| project: | ||
| default: false # disable the default status that measures entire project | ||
| tests: # declare a new status context "tests" | ||
| target: 100% # we always want 100% coverage here |
There was a problem hiding this comment.
100% is a high target -- 80% is sufficient?
There was a problem hiding this comment.
Right, the coverage is 100% for tests. I.e., all the test code you wrote was actually executed.
https://www.youtube.com/watch?v=70T6OxKwxm0
Although I'm not seeing our current test coverage in codecov, so I'm not sure this will work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds PR status checks for codecov.
See https://docs.codecov.com/docs/commit-status for more details on what this looks like