fixed dependencies and removed codecov

NVlabs · Jul 22, 2024 · 811f854 · 811f854
1 parent 4f8bc3d
commit 811f854
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 19 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -55,19 +55,11 @@ jobs:
         lcov --capture --directory . --output-file coverage.info
         lcov --remove coverage.info '/usr/*' --output-file coverage.info
         lcov --list coverage.info
-  
-    - name: Upload Python coverage to Codecov
-      uses: codecov/codecov-action@v2
+ 
+    - name: Upload coverage reports as artifacts
+      uses: actions/upload-artifact@v2
       with:
-        files: ./coverage.xml
-        flags: python
-        name: python-coverage
-        fail_ci_if_error: true
-
-    - name: Upload C++ coverage to Codecov
-      uses: codecov/codecov-action@v2
-      with:
-        files: ./coverage.info
-        flags: cpp
-        name: cpp-coverage
-        fail_ci_if_error: true
+        name: coverage-reports
+        path: |
+          coverage.xml
+          coverage.info
diff --git a/README.md b/README.md
@@ -4,8 +4,8 @@ GBRL is a Python-based Gradient Boosting Trees (GBT) library, similar to popular
 [![Build Status](https://img.shields.io/github/workflow/status/Nvlabs/gbrl/CI)](https://github.com/NVlabs/gbrl/actions)
 [![License](https://img.shields.io/badge/license-NVIDIA-green.svg)](https://nvlabs.github.io/gbrl/license.htm)
 [![PyPI version](https://badge.fury.io/py/gbrl.svg)](https://badge.fury.io/py/gbrl)
-[![Python Coverage](https://codecov.io/gh/Nvlabs/gbrl/branch/master/graph/badge.svg?flag=python)](https://codecov.io/gh/Nvlabs/gbrl)
-[![C++ Coverage](https://codecov.io/gh/Nvlabs/gbrl/branch/master/graph/badge.svg?flag=cpp)](https://codecov.io/gh/Nvlabs/gbrl)
+<!-- [![Python Coverage](https://codecov.io/gh/Nvlabs/gbrl/branch/master/graph/badge.svg?flag=python)](https://codecov.io/gh/Nvlabs/gbrl)
+[![C++ Coverage](https://codecov.io/gh/Nvlabs/gbrl/branch/master/graph/badge.svg?flag=cpp)](https://codecov.io/gh/Nvlabs/gbrl) -->
 
 ## Overview
 

diff --git a/pyproject.toml b/pyproject.toml
@@ -23,7 +23,7 @@ dependencies = [
     "numpy>=1.21.0",
     "cmake>=3.18",
     "torch>=1.10.0",
-    "scikit-learn>=1.0.0",
+    "scikit-learn>=1.5.0",
     "scipy>=1.7.0",
     "shap>=0.40.0",
     "matplotlib>=3.5.0",
@@ -56,7 +56,7 @@ pybind11 = {version = "2.13.1", extras = ["global"]}
 numpy = ">=1.21.0"
 cmake = ">=3.18"
 torch = ">=1.10.0"
-scikit-learn = ">=1.0.0"
+scikit-learn = ">=1.5.0"
 scipy = ">=1.7.0"
 shap = ">=0.40.0"
 matplotlib = ">=3.5.0"