fix(skills): avoid mislabeling local skills as builtin in skills list#862
Open
arceus77-7 wants to merge 1 commit intoNousResearch:mainfrom
Open
fix(skills): avoid mislabeling local skills as builtin in skills list#862arceus77-7 wants to merge 1 commit intoNousResearch:mainfrom
arceus77-7 wants to merge 1 commit intoNousResearch:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes incorrect source labeling in
hermes skills list.Previously, every non-hub-installed skill was shown as
builtin. This misclassified user-managed skills (for example skills synced in from external managers) as built-in Hermes skills.This PR classifies installed skills into:
hub(present in Hub lockfile)builtin(present in bundled skills manifest)local(everything else under~/.hermes/skills/)It also adds a
--source localfilter.Related Issue
Fixes #861
Type of Change
Changes Made
hermes_cli/skills_hub.py(do_list):tools.skills_sync._read_manifest().hub,builtin, andlocalskills./skillshelp text to document--source hub|builtin|local.hermes_cli/main.pyto includelocal.tests/hermes_cli/test_skills_hub.py:test_do_list_distinguishes_hub_builtin_and_localtest_do_list_local_filterHow to Test
./venv/bin/pytest tests/hermes_cli/test_skills_hub.py -q~/.hermes/skills/.hermes skills listhermes skills list --source localSource=localand no longer appears asbuiltin.Checklist
Code
fix(scope):,feat(scope):, etc.)Documentation & Housekeeping
Screenshots / Logs
./venv/bin/pytest tests/hermes_cli/test_skills_hub.py -q->3 passedpytest tests/ -qwas not run for this focused fix.