[RPC]: deliver infos for missing packs by edriouk · Pull Request #2463 · Open-CMSIS-Pack/devtools

edriouk · 2026-04-28T17:08:40Z

Fixes

[RPC]: deliver infos for missing packs #2461

Changes

Checklist

🤖 This change is covered by unit tests (if applicable).
🤹 Manual testing has been performed (if necessary).
🛡️ Security impacts have been considered (if relevant).
📖 Documentation updates are complete (if required).
🧠 Third-party dependencies and TPIP updated (if required).

#2461

Copilot

Pull request overview

This PR updates the ProjMgr RPC GetPacksInfo behavior so that pack info entries are also returned for packs that are referenced/required but not installed, enabling better UI presentation for missing packs (fixes #2461).

Changes:

Track a resolved pack ID during pack requirement collection (PackageItem::resolvedTo) and use it for RPC pack references.
Extend GetPacksInfo to append entries for unresolved (missing) pack references.
Update/extend unit + RPC tests and PackMissing test data to cover missing-pack scenarios.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tools/projmgr/src/ProjMgrWorker.cpp	Stores resolved pack ID during PDSC resolution; relaxes pack-loading failure behavior in RPC mode.
tools/projmgr/include/ProjMgrWorker.h	Adds `PackageItem::resolvedTo` to carry resolved pack ID for RPC/UI.
tools/projmgr/src/ProjMgrRpcServer.cpp	Uses `resolvedTo` for pack references and appends unresolved pack infos in `GetPacksInfo`.
tools/projmgr/test/src/ProjMgrRpcTests.cpp	Adds `RpcGetPacksInfoMissing` coverage for missing packs returned by `GetPacksInfo`.
tools/projmgr/test/src/ProjMgrUnitTests.cpp	Ensures PackMissing tests start from a clean state by removing generated cbuild-pack file.
tools/projmgr/test/data/TestSolution/PackMissing/missing_pack.csolution.yml	Adds a `Miss` context and additional pack requirements to exercise missing-pack reporting.
tools/projmgr/test/data/TestSolution/PackMissing/ref/missing_pack.cbuild-idx.yml	Updates expected cbuild-idx output to include the new context and info messages.
tools/projmgr/test/data/TestSolution/PackMissing/ref/missing_pack_specific_context.cbuild-idx.yml	Updates expected metadata to match current generator output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

github-actions · 2026-04-28T17:26:36Z

Test Results

3 files - 55 21 suites - 155 16m 50s ⏱️ - 4m 25s
462 tests - 450 462 ✅ - 433 0 💤 - 17 0 ❌ ±0
1 386 runs - 1 487 1 386 ✅ - 1 419 0 💤 - 68 0 ❌ ±0

Results for commit 01746a0. ± Comparison against base commit d511ad6.

This pull request removes 451 and adds 1 tests. Note that renamed tests count towards both.

AuxCmdTests ‑ MkdirCmdTest
AuxCmdTests ‑ RmdirCmdTest
AuxCmdTests ‑ TouchCmdTest
BuildSystemGeneratorTests ‑ GenAuditFile
BuildSystemGeneratorTests ‑ GenAuditFile_WithOut_Existing_Audit_File
BuildSystemGeneratorTests ‑ GenAuditFile_With_Existing_Audit_File
BuildSystemGeneratorTests ‑ GetString
BuildSystemGeneratorTests ‑ StrConv
BuildSystemGeneratorTests ‑ StrNorm
CBuildGCCTests ‑ Asm
…

ProjMgrRpcTests ‑ RpcGetPacksInfoMissing

♻️ This comment has been updated with latest results.

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

brondani

LGTM

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

codecov · 2026-04-30T09:06:41Z

Codecov Report

❌ Patch coverage is 85.36585% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.95%. Comparing base (d511ad6) to head (01746a0).

Files with missing lines	Patch %	Lines
tools/projmgr/src/ProjMgrRpcServer.cpp	85.29%	2 Missing and 3 partials ⚠️
tools/projmgr/src/ProjMgrWorker.cpp	85.71%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2463      +/-   ##
==========================================
+ Coverage   64.93%   64.95%   +0.02%     
==========================================
  Files         145      145              
  Lines       26321    26351      +30     
  Branches    15902    15923      +21     
==========================================
+ Hits        17091    17117      +26     
- Misses       7063     7065       +2     
- Partials     2167     2169       +2

Flag	Coverage Δ
projmgr-cov	`87.89% <85.36%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
tools/projmgr/include/ProjMgrWorker.h	`83.33% <ø> (ø)`
tools/projmgr/src/ProjMgrWorker.cpp	`87.36% <85.71%> (+0.01%)`	⬆️
tools/projmgr/src/ProjMgrRpcServer.cpp	`85.49% <85.29%> (-0.05%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov · 2026-04-30T09:36:10Z

Codecov Report

❌ Patch coverage is 85.36585% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.95%. Comparing base (d511ad6) to head (01746a0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
tools/projmgr/src/ProjMgrRpcServer.cpp	85.29%	2 Missing and 3 partials ⚠️
tools/projmgr/src/ProjMgrWorker.cpp	85.71%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2463      +/-   ##
==========================================
+ Coverage   64.93%   64.95%   +0.02%     
==========================================
  Files         145      145              
  Lines       26321    26351      +30     
  Branches    15902    15923      +21     
==========================================
+ Hits        17091    17117      +26     
- Misses       7063     7065       +2     
- Partials     2167     2169       +2

Flag	Coverage Δ
projmgr-cov	`87.89% <85.36%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
tools/projmgr/include/ProjMgrWorker.h	`83.33% <ø> (ø)`
tools/projmgr/src/ProjMgrWorker.cpp	`87.36% <85.71%> (+0.01%)`	⬆️
tools/projmgr/src/ProjMgrRpcServer.cpp	`85.49% <85.29%> (-0.05%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[RPC]: deliver infos for missing packs

b753dae

#2461

edriouk requested a review from Copilot April 28, 2026 17:08

Copilot started reviewing on behalf of edriouk April 28, 2026 17:09 View session

Copilot AI reviewed Apr 28, 2026

View reviewed changes

Comment thread tools/projmgr/src/ProjMgrWorker.cpp

Comment thread tools/projmgr/src/ProjMgrRpcServer.cpp

Comment thread tools/projmgr/src/ProjMgrRpcServer.cpp

edriouk added 5 commits April 29, 2026 09:48

Merge branch 'main' into missing-packs-rpc

4de8aaa

Merge branch 'main' into missing-packs-rpc

9243643

Merge branch 'main' into missing-packs-rpc

440cee0

Address copilot review

f895e52

Fix test

ebf2c08

edriouk requested a review from brondani April 30, 2026 07:26

edriouk mentioned this pull request Apr 30, 2026

error message remains in PROBLEMS tab after selecting an unavailable Pack Open-CMSIS-Pack/vscode-cmsis-solution#186

Closed

edriouk marked this pull request as ready for review April 30, 2026 07:28

brondani reviewed Apr 30, 2026

View reviewed changes

Comment thread tools/projmgr/src/ProjMgrRpcServer.cpp Outdated

Address review comment

0fff45f

edriouk requested a review from Copilot April 30, 2026 08:47

Copilot started reviewing on behalf of edriouk April 30, 2026 08:48 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread tools/projmgr/src/ProjMgrRpcServer.cpp Outdated

brondani previously approved these changes Apr 30, 2026

View reviewed changes

Update tools/projmgr/src/ProjMgrRpcServer.cpp

01746a0

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

edriouk dismissed brondani’s stale review via 01746a0 April 30, 2026 08:58

edriouk requested a review from brondani April 30, 2026 08:58

brondani approved these changes Apr 30, 2026

View reviewed changes

edriouk merged commit beb9bb8 into main Apr 30, 2026
33 checks passed

edriouk deleted the missing-packs-rpc branch April 30, 2026 09:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RPC]: deliver infos for missing packs#2463

[RPC]: deliver infos for missing packs#2463
edriouk merged 8 commits into
mainfrom
missing-packs-rpc

edriouk commented Apr 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 28, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

brondani left a comment

Uh oh!

codecov Bot commented Apr 30, 2026

Uh oh!

Uh oh!

codecov Bot commented Apr 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

edriouk commented Apr 28, 2026

Fixes

Changes

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

brondani left a comment

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Apr 30, 2026

Codecov Report

Uh oh!

Uh oh!

codecov Bot commented Apr 30, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Apr 28, 2026 •

edited

Loading