Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the #[RequiresActiveSession] attribute #210

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Implement the #[RequiresActiveSession] attribute #210

wants to merge 4 commits into from

Conversation

MKodde
Copy link
Member

@MKodde MKodde commented Sep 17, 2024 •
edited
Loading

Install the #[RequiresActiveSession] attribute on the routes that require a session to be started.

@pmeulen are these the actions you had in mind? This is what my own judgement came up with.

As a little side project I:

  • Dependency injected the Session name into the services that check the session id cookie
  • Injected the Salt that is used to generate the log session correlation id with.

@MKodde
Enable session requirement check for enrollment
6232444
@MKodde
Inject session name into the session check services
854e0d8 
That way we always follow the configured session name set in the
framework.yaml
@MKodde
Inject the correlation salt
96cc2cc 
That way we do not hard code a security measure in the code base. And
allow for manual setting of that SALT
@MKodde
Enable Session constraint testing on Authn routes
145fcb4
@MKodde MKodde requested a review from pmeulen September 17, 2024 09:22
@MKodde MKodde mentioned this pull request Sep 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeulen pmeulen Awaiting requested review from pmeulen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MKodde