-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the #[RequiresActiveSession]
attribute
#210
base: main
Are you sure you want to change the base?
Commits on Sep 2, 2024
-
First idea's for better handling of timeouts and sending a session id…
…entifier along with the polls
Configuration menu - View commit details
-
Copy full SHA for d06def8 - Browse repository at this point
Copy the full SHA d06def8View commit details
Commits on Sep 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f32114b - Browse repository at this point
Copy the full SHA f32114bView commit details
Commits on Sep 11, 2024
-
Bump twig/twig from 3.10.3 to 3.11.1
Bumps [twig/twig](https://github.com/twigphp/Twig) from 3.10.3 to 3.11.1. - [Changelog](https://github.com/twigphp/Twig/blob/v3.11.1/CHANGELOG) - [Commits](twigphp/Twig@v3.10.3...v3.11.1) --- updated-dependencies: - dependency-name: twig/twig dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 300e94d - Browse repository at this point
Copy the full SHA 300e94dView commit details -
Bump express from 4.19.2 to 4.20.0
Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.20.0. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.19.2...4.20.0) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ed1bb66 - Browse repository at this point
Copy the full SHA ed1bb66View commit details -
Make the Tiqr Configuration validation less cryptic
The Assert statements would yield unusable error messages without a path to know what to go and fix. This change at least tells us what config item is not right. And what is expected.
Configuration menu - View commit details
-
Copy full SHA for 6c059b9 - Browse repository at this point
Copy the full SHA 6c059b9View commit details -
Move Authn Status to own controller
Some additional bootstrapping was required to allow for this (in services.yaml).
Configuration menu - View commit details
-
Copy full SHA for 28c2667 - Browse repository at this point
Copy the full SHA 28c2667View commit details -
Configuration menu - View commit details
-
Copy full SHA for d0f67d3 - Browse repository at this point
Copy the full SHA d0f67d3View commit details -
When authn error occurs, send 'invalid-request'
This error status was previously not supported. It is now. The uncaught errors are caught, and the invalid-request is sent back to the JS app. That in turn displays the user facing error page.
Configuration menu - View commit details
-
Copy full SHA for 4f298a4 - Browse repository at this point
Copy the full SHA 4f298a4View commit details -
Handle unknown statuses as an error
At first I opted to handle the 'invalid-request' manually. But having a default switch-case to handle all unhandled stati as an error makes more sense. And before this commit, the invalid request was handled as a Push Notification failure. But that was not my intention. I wanted to render the error page, and for that, we need to call the switchToStatusRequestError method instead.
Configuration menu - View commit details
-
Copy full SHA for 745760b - Browse repository at this point
Copy the full SHA 745760bView commit details -
Apply PHPStan checks to the dev folder
Prior to this change none of the code in the dev folder was being scanned by PHPStan, resulting in a lot of errors which do not comply with our coding standards. This change is needed to improve code quality for our dev code. All existing errors are added to the baseline.
Configuration menu - View commit details
-
Copy full SHA for aea600e - Browse repository at this point
Copy the full SHA aea600eView commit details -
Set the type of the result of QrReader text function to mixed
Prior to this change the type was said to be a string, but we couldn't be sure. This change solves the issue by typing the result as mixed, then validating whether it was a string.
Configuration menu - View commit details
-
Copy full SHA for 70988c9 - Browse repository at this point
Copy the full SHA 70988c9View commit details -
Fix some of the newly introduced PHPStan errors
With the introduction of PHPStan scanning the dev folder a lot of errors were added to the baseline. I've taken a short time to look at the newly introduced errors and fixed some of them.
Configuration menu - View commit details
-
Copy full SHA for 384732b - Browse repository at this point
Copy the full SHA 384732bView commit details
Commits on Sep 16, 2024
-
That is added to isolate the timeout 'business' rules are implemented correctly. And make them testable.
Configuration menu - View commit details
-
Copy full SHA for afccf28 - Browse repository at this point
Copy the full SHA afccf28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bd5d71 - Browse repository at this point
Copy the full SHA 6bd5d71View commit details -
Configuration menu - View commit details
-
Copy full SHA for b75d4d8 - Browse repository at this point
Copy the full SHA b75d4d8View commit details -
Test the new registration state change
The Jest test was not yet covering the possibility of a registration timeout
Configuration menu - View commit details
-
Copy full SHA for 0285fa5 - Browse repository at this point
Copy the full SHA 0285fa5View commit details
Commits on Sep 17, 2024
-
Log every time a session is created
Prior to this change there we weren't able to keep track of sessions that got lost. This change allows us to see every time a session is created and distinguish them by their correlation id.
Configuration menu - View commit details
-
Copy full SHA for fd35804 - Browse repository at this point
Copy the full SHA fd35804View commit details -
Log an error on a route that requires an active session when there is…
… none Prior to this change all routes were able to called, even though the user might not have had an active session This change will start logging errors when the session wasn't found, or is in an unexpected state
Configuration menu - View commit details
-
Copy full SHA for f2a1dcf - Browse repository at this point
Copy the full SHA f2a1dcfView commit details -
Listen to all routes and log the state of the session
Prior to this change session information got lost. We had no way of tracking down what happened to user sessions in the logs. This change logs whether a session existed and if it's in a valid state. Log information is enriched with a correlation id to be able to distinguish them.
Configuration menu - View commit details
-
Copy full SHA for 4776494 - Browse repository at this point
Copy the full SHA 4776494View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6232444 - Browse repository at this point
Copy the full SHA 6232444View commit details -
Inject session name into the session check services
That way we always follow the configured session name set in the framework.yaml
Configuration menu - View commit details
-
Copy full SHA for 854e0d8 - Browse repository at this point
Copy the full SHA 854e0d8View commit details -
That way we do not hard code a security measure in the code base. And allow for manual setting of that SALT
Configuration menu - View commit details
-
Copy full SHA for 96cc2cc - Browse repository at this point
Copy the full SHA 96cc2ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 145fcb4 - Browse repository at this point
Copy the full SHA 145fcb4View commit details