Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the #[RequiresActiveSession] attribute #210

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Commits on Sep 2, 2024

  1. First idea's for better handling of timeouts and sending a session id…

    …entifier along with the polls
    pmeulen authored and MKodde committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    d06def8 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Configuration menu
    Copy the full SHA
    f32114b View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Bump twig/twig from 3.10.3 to 3.11.1

    Bumps [twig/twig](https://github.com/twigphp/Twig) from 3.10.3 to 3.11.1.
    - [Changelog](https://github.com/twigphp/Twig/blob/v3.11.1/CHANGELOG)
    - [Commits](twigphp/Twig@v3.10.3...v3.11.1)
    
    ---
    updated-dependencies:
    - dependency-name: twig/twig
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored and MKodde committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    300e94d View commit details
    Browse the repository at this point in the history
  2. Bump express from 4.19.2 to 4.20.0

    Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.20.0.
    - [Release notes](https://github.com/expressjs/express/releases)
    - [Changelog](https://github.com/expressjs/express/blob/master/History.md)
    - [Commits](expressjs/express@4.19.2...4.20.0)
    
    ---
    updated-dependencies:
    - dependency-name: express
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored and MKodde committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    ed1bb66 View commit details
    Browse the repository at this point in the history
  3. Make the Tiqr Configuration validation less cryptic

    The Assert statements would yield unusable error messages without a path
    to know what to go and fix. This change at least tells us what config
    item is not right. And what is expected.
    MKodde committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    6c059b9 View commit details
    Browse the repository at this point in the history
  4. Move Authn Status to own controller

    Some additional bootstrapping was required to allow for this (in
    services.yaml).
    MKodde committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    28c2667 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d0f67d3 View commit details
    Browse the repository at this point in the history
  6. When authn error occurs, send 'invalid-request'

    This error status was previously not supported. It is now. The uncaught
    errors are caught, and the invalid-request is sent back to the JS app.
    
    That in turn displays the user facing error page.
    MKodde committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    4f298a4 View commit details
    Browse the repository at this point in the history
  7. Handle unknown statuses as an error

    At first I opted to handle the 'invalid-request' manually. But having a
    default switch-case to handle all unhandled stati as an error makes more
    sense.
    
    And before this commit, the invalid request was handled as a Push
    Notification failure. But that was not my intention. I wanted to render
    the error page, and for that, we need to call the switchToStatusRequestError
    method instead.
    MKodde committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    745760b View commit details
    Browse the repository at this point in the history
  8. Apply PHPStan checks to the dev folder

    Prior to this change none of the code in the dev folder was being scanned by PHPStan, resulting in a lot of errors which do not comply with our coding standards.
    
    This change is needed to improve code quality for our dev code. All existing errors are added to the baseline.
    mharte-ib authored and MKodde committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    aea600e View commit details
    Browse the repository at this point in the history
  9. Set the type of the result of QrReader text function to mixed

    Prior to this change the type was said to be a string, but we couldn't be sure.
    This change solves the issue by typing the result as mixed, then validating whether it was a string.
    mharte-ib authored and MKodde committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    70988c9 View commit details
    Browse the repository at this point in the history
  10. Fix some of the newly introduced PHPStan errors

    With the introduction of PHPStan scanning the dev folder a lot of errors were added to the baseline.
    
    I've taken a short time to look at the newly introduced errors and fixed some of them.
    mharte-ib authored and MKodde committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    384732b View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Add a timeout helper class

    That is added to isolate the timeout 'business' rules are implemented
    correctly. And make them testable.
    MKodde committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    afccf28 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6bd5d71 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b75d4d8 View commit details
    Browse the repository at this point in the history
  4. Test the new registration state change

    The Jest test was not yet covering the possibility of a registration
    timeout
    MKodde committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    0285fa5 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Log every time a session is created

    Prior to this change there we weren't able to keep track of sessions that got lost.
    
    This change allows us to see every time a session is created and distinguish them by their correlation id.
    mharte-ib authored and MKodde committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    fd35804 View commit details
    Browse the repository at this point in the history
  2. Log an error on a route that requires an active session when there is…

    … none
    
    Prior to this change all routes were able to called, even though the user might not have had an active session
    
    This change will start logging errors when the session wasn't found, or is in an unexpected state
    mharte-ib authored and MKodde committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f2a1dcf View commit details
    Browse the repository at this point in the history
  3. Listen to all routes and log the state of the session

    Prior to this change session information got lost. We had no way of tracking down what happened to user sessions in the logs.
    
    This change logs whether a session existed and if it's in a valid state. Log information is enriched with a correlation id to be able to distinguish them.
    mharte-ib authored and MKodde committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    4776494 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6232444 View commit details
    Browse the repository at this point in the history
  5. Inject session name into the session check services

    That way we always follow the configured session name set in the
    framework.yaml
    MKodde committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    854e0d8 View commit details
    Browse the repository at this point in the history
  6. Inject the correlation salt

    That way we do not hard code a security measure in the code base. And
    allow for manual setting of that SALT
    MKodde committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    96cc2cc View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    145fcb4 View commit details
    Browse the repository at this point in the history