fix: handle invalid byte sizes#13
Open
alibababye wants to merge 1 commit into
Open
Conversation
Guard byte formatting against invalid and sub-byte values so the UI does not render NaN or undefined units.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I noticed
formatBytescould render odd values for small or invalid artifact sizes.For values between 0 and 1 byte,
Math.log(bytes)made the unit index negative, which produced output like512.0 undefined. Negative or non-finite values could also render asNaN undefined.This PR guards invalid/non-positive values, clamps the selected unit, and adds a small Vitest regression test for the edge cases. I also added the missing Vitest setup file referenced by
vite.config.ts, so the new frontend test can run with the existing test config.Verified with:
npm install && npx vitest run src/lib/utils.test.ts npm run build