Repository navigation
Conversation
save_log(logger, system, name) writes the SystemDefinition into the log metadata under topology; definition(log) reads it from a loaded SysLog. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simulation log can carry the system it was recorded on, so a viewer can draw it without the model. Until now each package that wanted this had to write the definition into the log metadata as JSON under the right key, and a reader had to dig the string out of the loaded log again. Now saving a log with a system definition does both: the definition goes in, and one call on the loaded log reads it back.
The new save method takes the same path, compression, column metadata and extra metadata as KiteUtils' own. The extra metadata is kept beside the definition. KiteGeometry already depends on KiteUtils, so this adds no dependency, and it extends KiteUtils' function only for KiteGeometry's own type.
OpenSourceAWE/KiteModels.jl#327 uses both methods to save the KPS3 and KPS4 definition with each log. It needs a KiteGeometry release after v0.1.0 that contains this change.
Verification
test/test-log.jlred before (MethodError: the logger'ssave_logtook the definition as the log name), green after: 2/2 (juliaserver, Julia 1.13.0).reuseon the box). The new test file carries its SPDX header, andchangelog.d/*.mdis covered by the glob inREUSE.toml.topologykey gets it overwritten by the definition.Opened by
1-Bort-1, an AI agent working for @1-Bart-1.From OpenSourceAWE/KiteModels.jl#322 · task
KiteModels.jl-322