Skip to content

Write KA orientations to SysState, keep KS inside the model #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
1-Bart-1 wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Write KA orientations to SysState, keep KS inside the model #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7b4c4f1
Write KA orientations to SysState, keep KS inside the model
1-Bart-1 Aug 25, 2026
3f6bf46
Stop writing roll, pitch and yaw to SysState
1-Bart-1 Aug 26, 2026
52c9677
Build SysState with the KiteUtils 0.12 constructor and one-slot winch…
1-Bort-1 Sep 24, 2026
abe946b
Drop BREAKING from the KiteUtils 0.12 changelog entry
1-Bort-1 Sep 26, 2026
5407922
Merge #321 (KiteUtils 0.12 SysState migration) into frame-unification
1-Bort-1 Sep 27, 2026
a8a9d8a
Drop Julia 1.11
1-Bort-1 Sep 27, 2026
eb9d276
Build on KiteUtils 0.13: fromKS2KA names, KiteViewers from #56's branch
1-Bort-1 Sep 27, 2026
6bf76f9
Address review: stdlib compat for 1.13, trim calc_orient_quat docstring
1-Bort-1 Sep 28, 2026
eb2238a
merge: latest main
1-Bort-1 Oct 9, 2026
25e6bfa
merge: latest main
1-Bort-1 Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/Test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
fail-fast: false
matrix:
version:
- '1.11'
- '1.12'

@1-Bort-1 1-Bort-1 Sep 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR: Dropping Julia 1.11 from CI, the compat bound, the docs and the manifests is a separate breaking support change riding in a frame-conversion PR, and the card does not mention it at all (§1). The card needs to name it, or it belongs in its own PR.

@1-Bort-1 1-Bort-1 Sep 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 1.11 drop was agreed on this thread (option A) — this branch can't build without it, since WinchModels/AtmosphericModels 0.3.11 need 1.12. Now named in the PR body.

- '1'
os:
- ubuntu-latest
Expand Down Expand Up @@ -88,7 +88,7 @@ jobs:
fail-fast: false
matrix:
julia_version:
- "1.11"
- "1.12"
julia_arch:
- x64
os:
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ SPDX-License-Identifier: MIT
Julia 1.13 as a third choice (the default if it is already the active juliaup channel).

#### Changed
- Requires KiteUtils 0.12. `SysState(kps)` builds a single-winch, single-tether state,
so `winch_force`, `l_tether`, `v_reelout`, `set_force`, `set_torque` and `set_speed` hold one
value instead of four.
- `Parameters` compat widened to `0.12, 0.13`.
- `bin/install` and `bin/create_sys_image` pick the default manifest generically as
`Manifest-v<julia_major>.toml.default` and fail if it is missing; `bin/create_sys_image` no longer
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ Before creating a new release, please check
- test_installation5 work
- execute `meld README.md docs/src/index.md` and make sure both are up-to-date
- test the installation on Linux for all Julia versions listed in the `julia` compat entry of
`Project.toml` (currently 1.11 and 1.12)
`Project.toml` (currently 1.12 and 1.13)

@1-Bort-1 1-Bort-1 Sep 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR: This line claims the package supports 1.13 on Linux, but CI's matrix is '1.12' and '1' and the stdlib compat entries stop at 1.12, so nothing here tests 1.13.

@1-Bort-1 1-Bort-1 Sep 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not changed: CI's '1' cell resolves to 1.13 (ci-local ran 1.13.0). The stdlib compat gap you found is fixed in 6bf76f9.

- test the installation on Windows after deleting the .julia folder
- run `pipx run reuse lint` and make sure all files have a license attached;
See: <https://reuse.readthedocs.io/en/latest/readme.html>
Loading
Loading