fix(shared-data): fix getPipetteSpecsV2 finding PEEK pipette specs #17296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix RQA-3852
Overview
The display name for the peek pipette was missing from run log because
getPipetteSpecsV2wasn't constructing the correct path to pull in general and geometry specs.Test Plan and Hands on Testing
Look at run log for a protocol that uses the PEEK pipette - see that the display name is now pulled in correctly
Changelog
Update
getHighestVersionutil in pipettes to take into account the_emin the pipette name, and allow for a highest minor version equal to 0Review requests
Was there a reason that we assumed minor version had to be higher than 0?
Risk assessment
Low