Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared-data): fix getPipetteSpecsV2 finding PEEK pipette specs #17296

Merged
merged 1 commit into from
Jan 17, 2025
+4 −2
Merged

fix(shared-data): fix getPipetteSpecsV2 finding PEEK pipette specs #17296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions shared-data/js/pipettes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ const getHighestVersion = (
path: string,
pipetteModel: string,
channels: Channels | null,
oemString: string,
majorVersion: number,
highestVersion: string
): string => {
Expand All @@ -174,10 +175,10 @@ const getHighestVersion = (
// and make sure the given model, channels, and major/minor versions
// are found in the path
if (
minorPathVersion > minorHighestVersion &&
minorPathVersion >= minorHighestVersion &&
path.includes(`${majorPathVersion}_${minorPathVersion}`) &&
path.includes(pipetteModel) &&
path.includes(channels ?? '')
path.includes(channels != null ? `${channels}${oemString}` : '')
) {
highestVersion = `${majorPathVersion}_${minorPathVersion}`
}
Expand Down Expand Up @@ -239,6 +240,7 @@ export const getPipetteSpecsV2 = (
path,
pipetteModel,
channels,
oemString,
majorVersion,
highestVersion
)
Expand Down
Loading